Objective C API to read and set RtpParameters

webrtc/api/objc/RTCPeerConnection.mm

 /*
  *  Copyright 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #import "webrtc/api/objc/RTCPeerConnection.h"
 
 #include "webrtc/base/checks.h"
 
 #import "webrtc/api/objc/RTCPeerConnection+Private.h"
 #import "webrtc/api/objc/RTCConfiguration+Private.h"
 #import "webrtc/api/objc/RTCDataChannel+Private.h"
 #import "webrtc/api/objc/RTCIceCandidate+Private.h"
 #import "webrtc/api/objc/RTCMediaConstraints+Private.h"
 #import "webrtc/api/objc/RTCMediaStream+Private.h"
 #import "webrtc/api/objc/RTCPeerConnectionFactory+Private.h"
+#import "webrtc/api/objc/RTCRtpSender+Private.h"
 #import "webrtc/api/objc/RTCSessionDescription+Private.h"
 #import "webrtc/api/objc/RTCStatsReport+Private.h"
 #import "webrtc/base/objc/RTCLogging.h"
 #import "webrtc/base/objc/NSString+StdString.h"
 
 NSString * const kRTCPeerConnectionErrorDomain =
     @"org.webrtc.RTCPeerConnection";
 int const kRTCPeerConnnectionSessionDescriptionError = -1;
 
 namespace webrtc {
@@ skipping 272 matching lines @@
 }
 
 - (void)setRemoteDescription:(RTCSessionDescription *)sdp
            completionHandler:(void (^)(NSError *error))completionHandler {
   rtc::scoped_refptr<webrtc::SetSessionDescriptionObserverAdapter> observer(
       new rtc::RefCountedObject<webrtc::SetSessionDescriptionObserverAdapter>(
           completionHandler));
   _peerConnection->SetRemoteDescription(observer, sdp.nativeDescription);
 }
 
+- (NSArray<RTCRtpSender*>*)senders {

[tkchin_webrtc, 2016/04/05 18:48:15]

ditto Sender *> *)

[skvlad, 2016/04/05 23:21:27]

Done.

+  std::vector<rtc::scoped_refptr<webrtc::RtpSenderInterface>> nativeSenders(

[tkchin_webrtc, 2016/04/05 18:48:15]

Clearly rusty on c++ -> compiler doesn't barf on >> anymore?

[skvlad, 2016/04/05 23:21:27]

Since C++ 11 it isn't supposed to, and the Chromium .clang-format file appears
to prefer no space:
https://code.google.com/p/chromium/codesearch#chromium/src/.clang-format

+      _peerConnection->GetSenders());
+  NSMutableArray* senders = [[NSMutableArray alloc] init];

[tkchin_webrtc, 2016/04/05 18:48:15]

pointer style: NSMutableArray *senders =

[skvlad, 2016/04/05 23:21:27]

Done.

+  for (auto nativeSender : nativeSenders) {

[Taylor Brandstetter, 2016/04/05 17:48:03]

nit: I think this creates a copy of the scoped_refptrs; usually we use "const
auto&" to avoid this, though it shouldn't really matter.

[tkchin_webrtc, 2016/04/05 18:48:15]

Consider adding a category in webrtc/base/objc similar to NSString+StdString to
deal with these common conversions (vector to NSArray, NSArray to vector).

[skvlad, 2016/04/05 23:21:27]

Is there a way to define a generic NSArray to vector<T> conversion function?
Otherwise it's probably better to keep it local, as no other code will need to
convert a vector<refptr<RtpSenderInterface>> to an array.

[skvlad, 2016/04/05 23:21:27]

Done.

+    RTCRtpSender* sender =
+        [[RTCRtpSender alloc] initWithNativeRtpSender:nativeSender];
+    [senders addObject:sender];
+  }
+  return senders;
+}
+
 #pragma mark - Private
 
 + (webrtc::PeerConnectionInterface::SignalingState)nativeSignalingStateForState:
     (RTCSignalingState)state {
   switch (state) {
     case RTCSignalingStateStable:
       return webrtc::PeerConnectionInterface::kStable;
     case RTCSignalingStateHaveLocalOffer:
       return webrtc::PeerConnectionInterface::kHaveLocalOffer;
     case RTCSignalingStateHaveLocalPrAnswer:
@@ skipping 150 matching lines @@
     case RTCStatsOutputLevelDebug:
       return webrtc::PeerConnectionInterface::kStatsOutputLevelDebug;
   }
 }
 
 - (rtc::scoped_refptr<webrtc::PeerConnectionInterface>)nativePeerConnection {
   return _peerConnection;
 }
 
 @end