Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 1854103002: Android VideoCapture: Add null checks in stopCaptureOnCameraThread (Closed)

Created:
4 years, 8 months ago by magjed_webrtc
Modified:
4 years, 8 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android VideoCapture: Add null checks in stopCaptureOnCameraThread If stopCapture is called shortly after startCapture, and the first startCaptureOnCameraThread failed, but still hasn't retried 3 times, stopCaptureOnCameraThread will be called in a state where the camera is not initialized. This CL adds null checks in stopCaptureOnCameraThread to avoid crashes. BUG=b/27939867 Committed: https://crrev.com/23b08eb531aef7d2c69512622c46cf2dab965207 Cr-Commit-Position: refs/heads/master@{#12234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
magjed_webrtc
Alex - please take a look.
4 years, 8 months ago (2016-04-04 13:27:54 UTC) #3
AlexG
lgtm
4 years, 8 months ago (2016-04-04 17:15:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854103002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854103002/1
4 years, 8 months ago (2016-04-05 08:03:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 08:37:09 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 08:37:12 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23b08eb531aef7d2c69512622c46cf2dab965207
Cr-Commit-Position: refs/heads/master@{#12234}

Powered by Google App Engine
This is Rietveld 408576698