webrtc/modules/video_coding/generic_encoder.h - Issue 1853813002: Add support for writing raw encoder output to .ivf files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/generic_encoder.h

Issue 1853813002: Add support for writing raw encoder output to .ivf files. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Moved file recording to ViEEncoder Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/modules/video_coding/generic_encoder.cc » ('j') | webrtc/modules/video_coding/utility/ivf_file_writer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/generic_encoder.h

diff --git a/webrtc/modules/video_coding/generic_encoder.h b/webrtc/modules/video_coding/generic_encoder.h

index e96d99578150f7b531445e14cb35f46995070801..77a73bcedf26147e5d0d1ebe42978d177e1904c8 100644

--- a/webrtc/modules/video_coding/generic_encoder.h

+++ b/webrtc/modules/video_coding/generic_encoder.h

@@ -71,17 +71,13 @@ class VCMEncodedFrameCallback : public EncodedImageCallback {

const char* encoder_implementation_name);

private:

- VCMPacketizationCallback* send_callback_;

- media_optimization::MediaOptimization* _mediaOpt;

- uint8_t _payloadType;

- bool _internalSource;

- VideoRotation _rotation;

+ VCMPacketizationCallback* send_callback_;

+ media_optimization::MediaOptimization* _mediaOpt;

+ uint8_t _payloadType;

+ bool _internalSource;

+ VideoRotation _rotation;

pbos-webrtc 2016/04/05 13:31:27 Can you git cl format this entire class so that we

sprang_webrtc 2016/04/05 16:00:53 Done, reformatted and cleaned up generic_encoder.(

- EncodedImageCallback* post_encode_callback_;

-#ifdef DEBUG_ENCODER_BIT_STREAM

- FILE* _bitStreamAfterEncoder;

-#endif

+ EncodedImageCallback* post_encode_callback_;

}; // end of VCMEncodeFrameCallback class

/******************************/