Make naming of APM perf test consistent

webrtc/modules/audio_processing/audio_processing_performance_unittest.cc

Index: webrtc/modules/audio_processing/audio_processing_performance_unittest.cc
diff --git a/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc b/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc
index a4a8351a17a15fbda4147116e3d8d4126dcb9041..1a934628b72ba633e570f78cd3400a23853762f4 100644
--- a/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc
+++ b/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc
@@ -47,8 +47,8 @@ enum class SettingsType {
   kDefaultApmDesktopAndBeamformer,
   kDefaultApmDesktopAndIntelligibilityEnhancer,
   kAllSubmodulesTurnedOff,
-  kDefaultDesktopApmWithoutDelayAgnostic,
-  kDefaultDesktopApmWithoutExtendedFilter
+  kDefaultApmdeskTopWithoutDelayAgnostic,

[hlundin-webrtc, 2016/04/03 09:50:49]

I think the capitalization is weird. ApmdeskTop -> ApmDesktop.

[phoglund, 2016/04/04 09:11:18]

+1

[aluebs-webrtc, 2016/04/04 22:17:54]

Thank you for catching this. The whole point of this CL of making the naming
consistent would have been missed. Who makes the default of a replace feature to
"preserve case"?

+  kDefaultApmdeskTopWithoutExtendedFilter
 };
 
 // Variables related to the audio data and formats.
@@ -85,8 +85,8 @@ struct SimulationConfig {
 #ifndef WEBRTC_ANDROID
     const SettingsType desktop_settings[] = {
         SettingsType::kDefaultApmDesktop, SettingsType::kAllSubmodulesTurnedOff,
-        SettingsType::kDefaultDesktopApmWithoutDelayAgnostic,
-        SettingsType::kDefaultDesktopApmWithoutExtendedFilter};
+        SettingsType::kDefaultApmdeskTopWithoutDelayAgnostic,
+        SettingsType::kDefaultApmdeskTopWithoutExtendedFilter};
 
     const int desktop_sample_rates[] = {8000, 16000, 32000, 48000};
 
@@ -151,11 +151,11 @@ struct SimulationConfig {
       case SettingsType::kAllSubmodulesTurnedOff:
         description = "AllSubmodulesOff";
         break;
-      case SettingsType::kDefaultDesktopApmWithoutDelayAgnostic:
-        description = "DefaultDesktopApmWithoutDelayAgnostic";
+      case SettingsType::kDefaultApmdeskTopWithoutDelayAgnostic:
+        description = "DefaultApmdeskTopWithoutDelayAgnostic";
         break;
-      case SettingsType::kDefaultDesktopApmWithoutExtendedFilter:
-        description = "DefaultDesktopApmWithoutExtendedFilter";
+      case SettingsType::kDefaultApmdeskTopWithoutExtendedFilter:
+        description = "DefaultApmdeskTopWithoutExtendedFilter";
         break;
     }
     return description;
@@ -605,7 +605,7 @@ class CallSimulator : public ::testing::TestWithParam<SimulationConfig> {
         turn_off_default_apm_runtime_settings(apm_.get());
         break;
       }
-      case SettingsType::kDefaultDesktopApmWithoutDelayAgnostic: {
+      case SettingsType::kDefaultApmdeskTopWithoutDelayAgnostic: {
         Config config;
         config.Set<ExtendedFilter>(new ExtendedFilter(true));
         config.Set<DelayAgnostic>(new DelayAgnostic(false));
@@ -615,7 +615,7 @@ class CallSimulator : public ::testing::TestWithParam<SimulationConfig> {
         apm_->SetExtraOptions(config);
         break;
       }
-      case SettingsType::kDefaultDesktopApmWithoutExtendedFilter: {
+      case SettingsType::kDefaultApmdeskTopWithoutExtendedFilter: {
         Config config;
         config.Set<ExtendedFilter>(new ExtendedFilter(false));
         config.Set<DelayAgnostic>(new DelayAgnostic(true));