Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1853543003: Make naming of APM perf test consistent (Closed)

Created:
4 years, 8 months ago by aluebs-webrtc
Modified:
4 years, 8 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make naming of APM perf test consistent BUG=599953 Committed: https://crrev.com/bfedbf9eae66ed5dbe60939d0efe00fb4e26ccc0 Cr-Commit-Position: refs/heads/master@{#12225}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Fix case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M webrtc/modules/audio_processing/audio_processing_performance_unittest.cc View 1 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
aluebs-webrtc
4 years, 8 months ago (2016-04-01 21:12:33 UTC) #2
hlundin-webrtc
Drive-by. https://codereview.webrtc.org/1853543003/diff/1/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc File webrtc/modules/audio_processing/audio_processing_performance_unittest.cc (right): https://codereview.webrtc.org/1853543003/diff/1/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc#newcode50 webrtc/modules/audio_processing/audio_processing_performance_unittest.cc:50: kDefaultApmdeskTopWithoutDelayAgnostic, I think the capitalization is weird. ApmdeskTop ...
4 years, 8 months ago (2016-04-03 09:50:49 UTC) #3
phoglund
lgtm if comment gets fixed https://codereview.webrtc.org/1853543003/diff/1/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc File webrtc/modules/audio_processing/audio_processing_performance_unittest.cc (right): https://codereview.webrtc.org/1853543003/diff/1/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc#newcode50 webrtc/modules/audio_processing/audio_processing_performance_unittest.cc:50: kDefaultApmdeskTopWithoutDelayAgnostic, On 2016/04/03 09:50:49, ...
4 years, 8 months ago (2016-04-04 09:11:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1853543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1853543003/20001
4 years, 8 months ago (2016-04-04 22:17:45 UTC) #7
aluebs-webrtc
https://codereview.webrtc.org/1853543003/diff/1/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc File webrtc/modules/audio_processing/audio_processing_performance_unittest.cc (right): https://codereview.webrtc.org/1853543003/diff/1/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc#newcode50 webrtc/modules/audio_processing/audio_processing_performance_unittest.cc:50: kDefaultApmdeskTopWithoutDelayAgnostic, On 2016/04/04 09:11:18, phoglund wrote: > On 2016/04/03 ...
4 years, 8 months ago (2016-04-04 22:17:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 23:53:42 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 23:53:50 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bfedbf9eae66ed5dbe60939d0efe00fb4e26ccc0
Cr-Commit-Position: refs/heads/master@{#12225}

Powered by Google App Engine
This is Rietveld 408576698