webrtc/modules/audio_coding/neteq/neteq_impl.h - Issue 1853183002: Change NetEq::GetPlayoutTimestamp to return an rtc::Optional<uint32_t>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/neteq_impl.h

Issue 1853183002: Change NetEq::GetPlayoutTimestamp to return an rtc::Optional<uint32_t> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Adding back the old PlayoutTimestamp method, now DEPRECATED Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/neteq/include/neteq.h ('k') | webrtc/modules/audio_coding/neteq/neteq_impl.cc » ('j') | webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/neteq_impl.h

diff --git a/webrtc/modules/audio_coding/neteq/neteq_impl.h b/webrtc/modules/audio_coding/neteq/neteq_impl.h

index 514fdaad39826f3429723225e2a791d624b22c8a..737efd46dafc98b2586ca82e6a1938eb3ee130f4 100644

--- a/webrtc/modules/audio_coding/neteq/neteq_impl.h

+++ b/webrtc/modules/audio_coding/neteq/neteq_impl.h

@@ -160,7 +160,7 @@ class NetEqImpl : public webrtc::NetEq {

// Disables post-decode VAD.

void DisableVad() override;

- bool GetPlayoutTimestamp(uint32_t* timestamp) override;

+ rtc::Optional<uint32_t> GetPlayoutTimestamp() override;

int last_output_sample_rate_hz() const override;