Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: webrtc/modules/audio_coding/neteq/neteq_unittest.cc

Issue 1853183002: Change NetEq::GetPlayoutTimestamp to return an rtc::Optional<uint32_t> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing Minyue's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/neteq/neteq_unittest.cc
diff --git a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc
index 340cf581b6d80ec57516786b0b96ebaa62eb129b..00a878c890f4637e6c85ecd3930bb00d2e56a46e 100644
--- a/webrtc/modules/audio_coding/neteq/neteq_unittest.cc
+++ b/webrtc/modules/audio_coding/neteq/neteq_unittest.cc
@@ -1522,9 +1522,9 @@ void NetEqDecodingTest::DuplicateCng() {
}
uint32_t NetEqDecodingTest::PlayoutTimestamp() {
- uint32_t playout_timestamp = 0;
- EXPECT_TRUE(neteq_->GetPlayoutTimestamp(&playout_timestamp));
- return playout_timestamp;
+ rtc::Optional<uint32_t> playout_timestamp = neteq_->GetPlayoutTimestamp();
+ EXPECT_TRUE(playout_timestamp);
+ return playout_timestamp.value_or(0);
}
TEST_F(NetEqDecodingTest, DiscardDuplicateCng) { DuplicateCng(); }
@@ -1570,5 +1570,4 @@ TEST_F(NetEqDecodingTest, CngFirst) {
// Verify speech output.
EXPECT_EQ(AudioFrame::kNormalSpeech, out_frame_.speech_type_);
}
-
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698