webrtc/modules/audio_coding/test/APITest.cc - Issue 1853183002: Change NetEq::GetPlayoutTimestamp to return an rtc::Optional<uint32_t>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/test/APITest.cc

Issue 1853183002: Change NetEq::GetPlayoutTimestamp to return an rtc::Optional<uint32_t> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/neteq/neteq_unittest.cc ('K') | « webrtc/modules/audio_coding/neteq/neteq_unittest.cc ('k') | webrtc/modules/audio_coding/test/delay_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/test/APITest.cc

diff --git a/webrtc/modules/audio_coding/test/APITest.cc b/webrtc/modules/audio_coding/test/APITest.cc

index bf04d7c8252f0ed95264ceee19aa5849404549d3..cbfd93310c07df5da4fac292b9ac50bb99f9d903 100644

--- a/webrtc/modules/audio_coding/test/APITest.cc

+++ b/webrtc/modules/audio_coding/test/APITest.cc

@@ -688,7 +688,7 @@ void APITest::TestDelay(char side) {

CHECK_ERROR_MT(myACM->SetMinimumPlayoutDelay(*myMinDelay));

inTimestamp = myChannel->LastInTimestamp();

- CHECK_ERROR_MT(myACM->PlayoutTimestamp(&outTimestamp));

+ CHECK_ERROR_MT(myACM->PlayoutTimestamp() ? 0 : -1);

if (!_randomTest) {

myEvent->StartTimer(true, 30);

@@ -698,7 +698,7 @@ void APITest::TestDelay(char side) {

myEvent->Wait(1000);

inTimestamp = myChannel->LastInTimestamp();

- CHECK_ERROR_MT(myACM->PlayoutTimestamp(&outTimestamp));

+ CHECK_ERROR_MT(myACM->PlayoutTimestamp() ? 0 : -1);

//std::cout << outTimestamp << std::endl << std::flush;

estimDelay = (double) ((uint32_t)(inTimestamp - outTimestamp))

minyue-webrtc 2016/04/04 15:53:50 no value assigned to outTimestam

hlundin-webrtc 2016/04/04 21:02:54 Ouch. My bad. Thanks for catching this.