webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h - Issue 1853183002: Change NetEq::GetPlayoutTimestamp to return an rtc::Optional<uint32_t>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

Issue 1853183002: Change NetEq::GetPlayoutTimestamp to return an rtc::Optional<uint32_t> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/acm2/acm_receiver.cc ('K') | « webrtc/modules/audio_coding/acm2/acm_receiver.cc ('k') | webrtc/modules/audio_coding/acm2/audio_coding_module_impl.cc » ('j') | webrtc/modules/audio_coding/neteq/neteq_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

diff --git a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

index e463d29f9b53dddf3e94d5804371d2594b8d5583..7c0ecddb96d1b7a464607d551a946ab034e6b31b 100644

--- a/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

+++ b/webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

@@ -157,8 +157,7 @@ class AudioCodingModuleImpl final : public AudioCodingModule {

// Smallest latency NetEq will maintain.

int LeastRequiredDelayMs() const override;

- // Get playout timestamp.

- int PlayoutTimestamp(uint32_t* timestamp) override;

+ rtc::Optional<uint32_t> PlayoutTimestamp() override;

// Get 10 milliseconds of raw audio data to play out, and

// automatic resample to the requested frequency if > 0.