Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: webrtc/modules/audio_coding/include/audio_coding_module.h

Issue 1853183002: Change NetEq::GetPlayoutTimestamp to return an rtc::Optional<uint32_t> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing Minyue's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 633 matching lines...) Expand 10 before | Expand all | Expand 10 after
644 // is computed based on inter-arrival times and playout mode of NetEq. The 644 // is computed based on inter-arrival times and playout mode of NetEq. The
645 // actual delay is the maximum of least-required-delay and the minimum-delay 645 // actual delay is the maximum of least-required-delay and the minimum-delay
646 // specified by SetMinumumPlayoutDelay() API. 646 // specified by SetMinumumPlayoutDelay() API.
647 // 647 //
648 virtual int LeastRequiredDelayMs() const = 0; 648 virtual int LeastRequiredDelayMs() const = 0;
649 649
650 /////////////////////////////////////////////////////////////////////////// 650 ///////////////////////////////////////////////////////////////////////////
651 // int32_t PlayoutTimestamp() 651 // int32_t PlayoutTimestamp()
652 // The send timestamp of an RTP packet is associated with the decoded 652 // The send timestamp of an RTP packet is associated with the decoded
653 // audio of the packet in question. This function returns the timestamp of 653 // audio of the packet in question. This function returns the timestamp of
654 // the latest audio obtained by calling PlayoutData10ms(). 654 // the latest audio obtained by calling PlayoutData10ms(), or empty if no
655 // valid timestamp is available.
655 // 656 //
656 // Input: 657 virtual rtc::Optional<uint32_t> PlayoutTimestamp() = 0;
657 // -timestamp : a reference to a uint32_t to receive the
658 // timestamp.
659 // Return value:
660 // 0 if the output is a correct timestamp.
661 // -1 if failed to output the correct timestamp.
662 //
663 // TODO(tlegrand): Change function to return the timestamp.
664 virtual int32_t PlayoutTimestamp(uint32_t* timestamp) = 0;
665 658
666 /////////////////////////////////////////////////////////////////////////// 659 ///////////////////////////////////////////////////////////////////////////
667 // int32_t PlayoutData10Ms( 660 // int32_t PlayoutData10Ms(
668 // Get 10 milliseconds of raw audio data for playout, at the given sampling 661 // Get 10 milliseconds of raw audio data for playout, at the given sampling
669 // frequency. ACM will perform a resampling if required. 662 // frequency. ACM will perform a resampling if required.
670 // 663 //
671 // Input: 664 // Input:
672 // -desired_freq_hz : the desired sampling frequency, in Hertz, of the 665 // -desired_freq_hz : the desired sampling frequency, in Hertz, of the
673 // output audio. If set to -1, the function returns 666 // output audio. If set to -1, the function returns
674 // the audio at the current sampling frequency. 667 // the audio at the current sampling frequency.
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 virtual std::vector<uint16_t> GetNackList( 783 virtual std::vector<uint16_t> GetNackList(
791 int64_t round_trip_time_ms) const = 0; 784 int64_t round_trip_time_ms) const = 0;
792 785
793 virtual void GetDecodingCallStatistics( 786 virtual void GetDecodingCallStatistics(
794 AudioDecodingCallStats* call_stats) const = 0; 787 AudioDecodingCallStats* call_stats) const = 0;
795 }; 788 };
796 789
797 } // namespace webrtc 790 } // namespace webrtc
798 791
799 #endif // WEBRTC_MODULES_AUDIO_CODING_INCLUDE_AUDIO_CODING_MODULE_H_ 792 #endif // WEBRTC_MODULES_AUDIO_CODING_INCLUDE_AUDIO_CODING_MODULE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698