Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1852573002:
Give a more specific URL for creating WebRTC checkout (Closed)
|
Created:
4 years, 8 months ago by brucedawson Modified:
4 years, 8 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionGive a more specific URL for creating WebRTC checkout
It's difficult to find the instructions to create a WebRTC checkout from
http://www.webrtc.org. This points at a more specific page, and uses
https because moartls.
NOTRY=True
TBR=mflodman@webrtc.org
Committed: https://crrev.com/109b5e656c26c152e28c76a60199c9a775aa04dc
Cr-Commit-Position: refs/heads/master@{#12191}
Patch Set 1 #Patch Set 2 : Better word wrap. #Messages
Total messages: 17 (9 generated)
brucedawson@chromium.org changed reviewers: + kjellander@webrtc.org
I don't know if the web site changed since we last tweaked this file or if I didn't notice the difficulty of finding the right page, but this should make it much easier. Whadya think?
Description was changed from ========== Give a more specific URL for creating WebRTC checkout It's difficult to find the instructions to create a WebRTC checkout from http://www.webrtc.org. This points at a more specific page, and uses https because moartls. ========== to ========== Give a more specific URL for creating WebRTC checkout It's difficult to find the instructions to create a WebRTC checkout from http://www.webrtc.org. This points at a more specific page, and uses https because moartls. NOTRY=True ==========
lgtm, thanks for fixing this!
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852573002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4537)
Description was changed from ========== Give a more specific URL for creating WebRTC checkout It's difficult to find the instructions to create a WebRTC checkout from http://www.webrtc.org. This points at a more specific page, and uses https because moartls. NOTRY=True ========== to ========== Give a more specific URL for creating WebRTC checkout It's difficult to find the instructions to create a WebRTC checkout from http://www.webrtc.org. This points at a more specific page, and uses https because moartls. NOTRY=True TBR=mflodman@webrtc.org ==========
kjellander@webrtc.org changed reviewers: + mflodman@webrtc.org
On 2016/04/01 07:18:03, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4537) TBR'ing mflodman@webrtc.org as root owner.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852573002/20001
Message was sent while issue was closed.
Description was changed from ========== Give a more specific URL for creating WebRTC checkout It's difficult to find the instructions to create a WebRTC checkout from http://www.webrtc.org. This points at a more specific page, and uses https because moartls. NOTRY=True TBR=mflodman@webrtc.org ========== to ========== Give a more specific URL for creating WebRTC checkout It's difficult to find the instructions to create a WebRTC checkout from http://www.webrtc.org. This points at a more specific page, and uses https because moartls. NOTRY=True TBR=mflodman@webrtc.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Give a more specific URL for creating WebRTC checkout It's difficult to find the instructions to create a WebRTC checkout from http://www.webrtc.org. This points at a more specific page, and uses https because moartls. NOTRY=True TBR=mflodman@webrtc.org ========== to ========== Give a more specific URL for creating WebRTC checkout It's difficult to find the instructions to create a WebRTC checkout from http://www.webrtc.org. This points at a more specific page, and uses https because moartls. NOTRY=True TBR=mflodman@webrtc.org Committed: https://crrev.com/109b5e656c26c152e28c76a60199c9a775aa04dc Cr-Commit-Position: refs/heads/master@{#12191} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/109b5e656c26c152e28c76a60199c9a775aa04dc Cr-Commit-Position: refs/heads/master@{#12191} |
