Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1850143002: GYP: Add webrtc/pc/pc.gyp:* to 'All' target. (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

GYP: Add webrtc/pc/pc.gyp:* to 'All' target. After moving the .isolate targets as part of https://codereview.webrtc.org/1843193002/ the rtc_pc_unittests_run target was no longer a part of the 'All' target. This caused it not being built, which causes Swarming to fail: https://build.chromium.org/p/client.webrtc.fyi/builders/Linux64%20Release%20%28swarming%29/builds/1678 Adding it to 'All' should fix this. TBR=pthatcher@webrtc.org BUG=webrtc:4243 Committed: https://crrev.com/4d689ad527a02001b7d16f75e6883a417edb2d81 Cr-Commit-Position: refs/heads/master@{#12195}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M webrtc/webrtc.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kjellander_webrtc
4 years, 8 months ago (2016-04-01 09:14:44 UTC) #1
kjellander_webrtc
Committed patchset #1 (id:1) manually as 4d689ad527a02001b7d16f75e6883a417edb2d81 (presubmit successful).
4 years, 8 months ago (2016-04-01 09:15:09 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 09:15:12 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d689ad527a02001b7d16f75e6883a417edb2d81
Cr-Commit-Position: refs/heads/master@{#12195}

Powered by Google App Engine
This is Rietveld 408576698