Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849243002: [rtcp] Bye::Parse updated not to use RTCPUtility (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 8 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] Bye::Parse updated not to use RTCPUtility BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/54a20696c2bff3baa9ba3c5a2d85845a72157431 Cr-Commit-Position: refs/heads/master@{#12244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -79 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.h View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/bye_unittest.cc View 3 chunks +47 lines, -67 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danilchap
4 years, 8 months ago (2016-04-01 14:17:30 UTC) #1
åsapersson
lgtm
4 years, 8 months ago (2016-04-05 12:41:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849243002/1
4 years, 8 months ago (2016-04-05 15:38:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 15:48:15 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 15:48:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/54a20696c2bff3baa9ba3c5a2d85845a72157431
Cr-Commit-Position: refs/heads/master@{#12244}

Powered by Google App Engine
This is Rietveld 408576698