Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1848813003: Remove deprecated RtpReceiver::CreateAudioReceiver() function. (Closed)

Created:
4 years, 8 months ago by the sun
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove deprecated RtpReceiver::CreateAudioReceiver() function. BUG=webrtc:4690 Committed: https://crrev.com/86101e9c088c287a70f63d2430935ce58c6427b7 Cr-Commit-Position: refs/heads/master@{#12192}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_receiver.h View 2 chunks +0 lines, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 1 chunk +0 lines, -13 lines 1 comment Download

Messages

Total messages: 15 (7 generated)
the sun
4 years, 8 months ago (2016-03-31 18:06:16 UTC) #3
hlundin-webrtc
lgtm https://codereview.webrtc.org/1848813003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc File webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc (left): https://codereview.webrtc.org/1848813003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc#oldcode18 webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc:18: #include "webrtc/base/logging.h" Can you remove any of these ...
4 years, 8 months ago (2016-03-31 18:22:47 UTC) #4
the sun
On 2016/03/31 18:22:47, hlundin-webrtc wrote: > lgtm > > https://codereview.webrtc.org/1848813003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc > File webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc (left): > ...
4 years, 8 months ago (2016-03-31 18:47:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848813003/1
4 years, 8 months ago (2016-03-31 18:47:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/11038)
4 years, 8 months ago (2016-03-31 19:07:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848813003/1
4 years, 8 months ago (2016-04-01 07:41:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 08:01:29 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 08:01:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86101e9c088c287a70f63d2430935ce58c6427b7
Cr-Commit-Position: refs/heads/master@{#12192}

Powered by Google App Engine
This is Rietveld 408576698