Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 1847973003: [rtcp] TransportFeedback adjusted to match other rtcp packets (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 4 months ago
Reviewers:
sprang_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] TransportFeedback adjusted to match other rtcp packets: Derived from rtcp::Rtpfb instead of directly from RtcpPacket Does not depend on RTCPUtility. Parse function takes CommonHeader. TransportFeedback::BlockLength fixed to match size used by Create BUG=webrtc:5260 Committed: https://crrev.com/642e3bc75b9e6052d11bdc1931ff7bc24248eae4 Cr-Commit-Position: refs/heads/master@{#13846}

Patch Set 1 #

Patch Set 2 : const -> constexpr #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : #

Patch Set 6 : rebase #

Patch Set 7 : remove redundant constant #

Patch Set 8 : rebase #

Patch Set 9 : Remove underused buffer check from Parse, added it to Create #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -140 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.h View 1 2 3 3 chunks +15 lines, -15 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc View 1 2 3 4 5 6 7 8 22 chunks +112 lines, -125 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
danilchap
4 years, 8 months ago (2016-04-01 14:18:50 UTC) #2
danilchap
ptal
4 years, 4 months ago (2016-08-22 06:32:01 UTC) #6
sprang_webrtc
lgtm
4 years, 4 months ago (2016-08-22 11:50:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/1847973003/160001
4 years, 4 months ago (2016-08-22 13:55:16 UTC) #9
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 4 months ago (2016-08-22 14:36:59 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 14:37:12 UTC) #13
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/642e3bc75b9e6052d11bdc1931ff7bc24248eae4
Cr-Commit-Position: refs/heads/master@{#13846}

Powered by Google App Engine
This is Rietveld 408576698