Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1954)

Unified Diff: webrtc/pc/channel_unittest.cc

Issue 1847353004: Allow applications to control audio send bitrate through RtpParameters. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Code review feedback Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/media/engine/webrtcvoiceengine.cc ('K') | « webrtc/pc/channel.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channel_unittest.cc
diff --git a/webrtc/pc/channel_unittest.cc b/webrtc/pc/channel_unittest.cc
index a423842e00d3f2baec4788980979659736f14a35..d84076ec2d64a5aea8d8a3ba5ac5d96dcd216d45 100644
--- a/webrtc/pc/channel_unittest.cc
+++ b/webrtc/pc/channel_unittest.cc
@@ -2357,24 +2357,12 @@ TEST_F(VoiceChannelTest, SendBundleToBundleWithRtcpMuxSecure) {
Base::SendBundleToBundle(kAudioPts, arraysize(kAudioPts), true, true);
}
-TEST_F(VoiceChannelTest, GetRtpParametersIsNotImplemented) {
- // These tests verify that the Get/SetRtpParameters methods for VoiceChannel
- // always fail as they are not implemented.
- // TODO(skvlad): Replace with full tests when support for bitrate limiting
- // for audio RtpSenders is added.
- CreateChannels(0, 0);
- EXPECT_TRUE(
- channel1_->SetLocalContent(&local_media_content1_, CA_OFFER, NULL));
- webrtc::RtpParameters voice_parameters = channel1_->GetRtpParameters(kSsrc1);
- EXPECT_EQ(0UL, voice_parameters.encodings.size());
+TEST_F(VoiceChannelTest, DefaultMaxBitrateIsUnlimited) {
+ Base::DefaultMaxBitrateIsUnlimited();
}
-TEST_F(VoiceChannelTest, SetRtpParametersIsNotImplemented) {
- CreateChannels(0, 0);
- EXPECT_TRUE(
- channel1_->SetLocalContent(&local_media_content1_, CA_OFFER, NULL));
- EXPECT_FALSE(
- channel1_->SetRtpParameters(kSsrc1, BitrateLimitedParameters(1000)));
+TEST_F(VoiceChannelTest, CanChangeMaxBitrate) {
+ Base::CanChangeMaxBitrate();
}
// VideoChannelTest
« webrtc/media/engine/webrtcvoiceengine.cc ('K') | « webrtc/pc/channel.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698