Set defines for Chromium build.

webrtc/build/common.gypi

 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 # This file contains common settings for building WebRTC components.
 
@@ skipping 245 matching lines @@
               # For WebRTC, we want it there as well, because ASSERT and
               # friends trigger off of it.
               '_DEBUG',
             ],
           },
         },
       }],
       ['build_with_chromium==1', {
         'defines': [
           # Changes settings for Chromium build.
+          'ENABLE_EXTERNAL_AUTH',
+          'EXPAT_RELATIVE_PATH',
+          'FEATURE_ENABLE_SSL',
+          'GTEST_RELATIVE_PATH',
+          'HAVE_OPENSSL_SSL_H',
+          'HAVE_SCTP',
+          'HAVE_SRTP',
+          'HAVE_WEBRTC_VIDEO',
+          'HAVE_WEBRTC_VOICE',
+          'LOGGING_INSIDE_WEBRTC',
+          'NO_MAIN_THREAD_WRAPPING',
+          'NO_SOUND_SYSTEM',
+          'SRTP_RELATIVE_PATH',
+          'SSL_USE_OPENSSL',
+          'USE_WEBRTC_DEV_BRANCH',
           'WEBRTC_CHROMIUM_BUILD',
-          'LOGGING_INSIDE_WEBRTC',
+        ],
+        'conditions': [
+          ['OS=="win" and target_arch=="ia32"', {
+            'defines': [
+              '_USE_32BIT_TIME_T',
+            ],
+          }],
         ],
         'include_dirs': [
           # Include the top-level directory when building in Chrome, so we can
           # use full paths (e.g. headers inside testing/ or third_party/).
           '<(DEPTH)',
           # The overrides must be included before the WebRTC root as that's the
           # mechanism for selecting the override headers in Chromium.
           '../../webrtc_overrides',
           # The WebRTC root is needed to allow includes in the WebRTC code base
           # to be prefixed with webrtc/.
@@ skipping 154 matching lines @@
              # functions. Ensure they are disabled for all compilers.
              'cflags': [
                '-fno-builtin-cos',
                '-fno-builtin-sin',
                '-fno-builtin-cosf',
                '-fno-builtin-sinf',
              ],
            }],
          ],
       }],
+      ['chromeos==1', {
+        'defines': [
+          'CHROMEOS',
+        ],
+      }],
+      ['os_bsd==1', {
+        'defines': [
+          'BSD',
+        ],
+      }],
+      ['OS=="openbsd"', {
+        'defines': [
+          'OPENBSD',
+        ],
+      }],
       ['include_internal_audio_device==1', {
         'defines': [
           'WEBRTC_INCLUDE_INTERNAL_AUDIO_DEVICE',
         ],
       }],
     ], # conditions
     'direct_dependent_settings': {
       'conditions': [
         ['build_with_mozilla==1', {
           'defines': [
             # Changes settings for Mozilla build.
             'WEBRTC_MOZILLA_BUILD',
            ],
         }],
         ['build_with_chromium==1', {
           'defines': [
             # Changes settings for Chromium build.
+            'FEATURE_ENABLE_SSL',
+            'FEATURE_ENABLE_VOICEMAIL',

[perkj_webrtc, 2016/04/01 09:33:47]

I don't think you need FEATURE_ENABLE_VOICEMAIL. 
Only used in webrtc/p2p/p2p.gyp and xmpp.gyp and there it is currently
conditioned on if 'build_with_chromium=0...

Are you sure all these actually still have a meaning? 

[kjellander_webrtc, 2016/04/01 10:34:36]

Initially I did a lot of grepping to see which defines are used, but then I
realized setting them on a per-project basis is doable, but will make reviewing
take longer and thus removing src/third_party/libjingle take even longer. In
this CL I try to just make the code behave the same for Chromium - then we can
do further cleanup later.

[tommi, 2016/04/01 13:23:09]

wanna put down a todo so that it won't be forgotten about?

[kjellander_webrtc, 2016/04/04 07:11:59]

Yepp, added TODOs in PS#3

+            'EXPAT_RELATIVE_PATH',
+            'GTEST_RELATIVE_PATH',
+            'NO_MAIN_THREAD_WRAPPING',
+            'NO_SOUND_SYSTEM',
             'WEBRTC_CHROMIUM_BUILD',
           ],
           'include_dirs': [
             # The overrides must be included first as that is the mechanism for
             # selecting the override headers in Chromium.
             '../../webrtc_overrides',
             '../..',
           ],
         }, {
           'include_dirs': [
             '../..',
           ],
         }],
         ['OS=="mac"', {
           'defines': [
             'WEBRTC_MAC',
           ],
         }],
         ['OS=="ios"', {
           'defines': [
             'WEBRTC_MAC',
             'WEBRTC_IOS',
           ],
         }],
         ['OS=="win"', {
           'defines': [
             'WEBRTC_WIN',
+            '_CRT_SECURE_NO_WARNINGS',  # Suppres warnings about _vsnprinf

[perkj_webrtc, 2016/04/01 09:33:47]

git grep "_vsnprinf" returns nothing. Not needed any more?

[kjellander_webrtc, 2016/04/01 10:34:36]

I don't know, I thought it may be used in system libraries that are in turn used
by our code. Considering how picky Chromium devs are about compiler warnings I
didn't dare removing it.

           ],
         }],
         ['OS=="linux"', {
           'defines': [
             'WEBRTC_LINUX',
           ],
         }],
         ['OS=="android"', {
           'defines': [
             'WEBRTC_LINUX',
             'WEBRTC_ANDROID',
            ],
         }],
         ['os_posix==1', {
           # For access to standard POSIXish features, use WEBRTC_POSIX instead
           # of a more specific macro.
           'defines': [
             'WEBRTC_POSIX',
           ],
         }],
+        ['chromeos==1', {
+          'defines': [
+            'CHROMEOS',
+          ],
+        }],
+        ['os_bsd==1', {
+          'defines': [
+            'BSD',
+          ],
+        }],
+        ['OS=="openbsd"', {
+          'defines': [
+            'OPENBSD',
+          ],
+        }],
       ],
     },
   }, # target_defaults
 }