Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1846433003: [rtcp] Sdes::Parse updated not to use RTCPUtility (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 8 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] Sdes::Parse updated not to use RTCPUtility BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/4b9cad86ce651952fdced0a4a08ea3c7d4365ec3 Cr-Commit-Position: refs/heads/master@{#12169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -40 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.h View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/sdes_unittest.cc View 15 chunks +19 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
åsapersson
lgtm
4 years, 8 months ago (2016-03-30 14:58:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1846433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1846433003/1
4 years, 8 months ago (2016-03-30 18:58:52 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 20:34:34 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:34:41 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4b9cad86ce651952fdced0a4a08ea3c7d4365ec3
Cr-Commit-Position: refs/heads/master@{#12169}

Powered by Google App Engine
This is Rietveld 408576698