Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1845943004:
setup_links.py: Use junctions instead of symlinks on Windows. (Closed)
|
Created:
4 years, 8 months ago by kjellander_webrtc Modified:
4 years, 8 months ago CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, brucedawson1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
Descriptionsetup_links.py: Use junctions instead of symlinks on Windows.
Instead of creating symlinks on Windows, the script is now:
* creating a junction for directories
* copying individual files.
This makes 'gclient sync' and 'gclient runhooks' no longer
require administrator's privileges.
If the script is run with administrator's privileges, a
warning will be printed, informing the user that it's not recommended.
Also clean up a few old documentation references to the
Chromium SVN->Git transition.
BUG=webrtc:4911
TESTED=Running the script with+without administrator's privileges.
I also tested the case of this change being rolled back, in which
case I verified that the copied files are still being deleted using
the same cleanup code path as the previous symlinks.
NOTRY=True
Committed: https://crrev.com/844dd2ad4bf7ecd6353a69a50105ea7c473f01f9
Cr-Commit-Position: refs/heads/master@{#12233}
Patch Set 1 : #
Total comments: 2
Messages
Total messages: 24 (16 generated)
Description was changed from ========== Remove symlinks to files and use Junctions on Windows. BUG=webrtc:4911 ========== to ========== setup_links.py: Use Junctions on Windows. This shouldn't require administrator's privileges. BUG=webrtc:4911 ==========
Patchset #1 (id:1) has been deleted
Description was changed from ========== setup_links.py: Use Junctions on Windows. This shouldn't require administrator's privileges. BUG=webrtc:4911 ========== to ========== setup_links.py: Use Junctions on Windows. This shouldn't require administrator's privileges. For files, just copy the file instead, since Junctions only works for directories. BUG=webrtc:4911 ==========
Patchset #1 (id:20001) has been deleted
Patchset #2 (id:60001) has been deleted
Patchset #1 (id:40001) has been deleted
Description was changed from ========== setup_links.py: Use Junctions on Windows. This shouldn't require administrator's privileges. For files, just copy the file instead, since Junctions only works for directories. BUG=webrtc:4911 ========== to ========== setup_links.py: Use Junctions on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. ==========
kjellander@webrtc.org changed reviewers: + pbos@webrtc.org
Description was changed from ========== setup_links.py: Use Junctions on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. ========== to ========== setup_links.py: Use Junctions on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. ==========
kjellander@webrtc.org changed reviewers: + tommi@webrtc.org - pbos@webrtc.org
Description was changed from ========== setup_links.py: Use Junctions on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. ========== to ========== setup_links.py: Use junctions instead of symlinks on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. ==========
lgtm
brucedawson@chromium.org changed reviewers: + brucedawson@chromium.org
Thanks for this! lgtm I assume there will be a corresponding change to the instructions on the web page to remove the administrator recommendation?
Description was changed from ========== setup_links.py: Use junctions instead of symlinks on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. ========== to ========== setup_links.py: Use junctions instead of symlinks on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. NOTRY=True ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845943004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845943004/80001
Message was sent while issue was closed.
Description was changed from ========== setup_links.py: Use junctions instead of symlinks on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. NOTRY=True ========== to ========== setup_links.py: Use junctions instead of symlinks on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. NOTRY=True ==========
Message was sent while issue was closed.
Committed patchset #1 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== setup_links.py: Use junctions instead of symlinks on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. NOTRY=True ========== to ========== setup_links.py: Use junctions instead of symlinks on Windows. Instead of creating symlinks on Windows, the script is now: * creating a junction for directories * copying individual files. This makes 'gclient sync' and 'gclient runhooks' no longer require administrator's privileges. If the script is run with administrator's privileges, a warning will be printed, informing the user that it's not recommended. Also clean up a few old documentation references to the Chromium SVN->Git transition. BUG=webrtc:4911 TESTED=Running the script with+without administrator's privileges. I also tested the case of this change being rolled back, in which case I verified that the copied files are still being deleted using the same cleanup code path as the previous symlinks. NOTRY=True Committed: https://crrev.com/844dd2ad4bf7ecd6353a69a50105ea7c473f01f9 Cr-Commit-Position: refs/heads/master@{#12233} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/844dd2ad4bf7ecd6353a69a50105ea7c473f01f9 Cr-Commit-Position: refs/heads/master@{#12233}
Message was sent while issue was closed.
https://codereview.webrtc.org/1845943004/diff/80001/setup_links.py File setup_links.py (right): https://codereview.webrtc.org/1845943004/diff/80001/setup_links.py#newcode96 setup_links.py:96: 'third_party/libevent', fyi - I noticed that this directory in Chromium is under src/base/third_party and not src/third_party. Does that mean webrtc doesn't really need it?
Message was sent while issue was closed.
https://codereview.webrtc.org/1845943004/diff/80001/setup_links.py File setup_links.py (right): https://codereview.webrtc.org/1845943004/diff/80001/setup_links.py#newcode96 setup_links.py:96: 'third_party/libevent', On 2016/04/16 19:41:33, tommi-webrtc wrote: > fyi - I noticed that this directory in Chromium is under src/base/third_party > and not src/third_party. Does that mean webrtc doesn't really need it? That seems to be the case. It must have been moved out at some point. Cleaning up in https://codereview.webrtc.org/1893953002/ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
