Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1845133002: Minor ObjC header updates. (Closed)

Created:
4 years, 8 months ago by tkchin_webrtc
Modified:
4 years, 8 months ago
Reviewers:
hjon_webrtc, Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Minor ObjC header updates. BUG= Committed: https://crrev.com/8b9ca953a44ce074db848734cc8b3d6138d26e93 Cr-Commit-Position: refs/heads/master@{#12183}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -66 lines) Patch
M webrtc/api/objc/RTCAVFoundationVideoSource.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/objc/RTCAudioTrack.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/api/objc/RTCAudioTrack+Private.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/objc/RTCDataChannel.h View 6 chunks +16 lines, -6 lines 0 comments Download
M webrtc/api/objc/RTCDataChannel.mm View 4 chunks +27 lines, -15 lines 0 comments Download
M webrtc/api/objc/RTCDataChannelConfiguration.h View 3 chunks +9 lines, -2 lines 0 comments Download
M webrtc/api/objc/RTCDataChannelConfiguration.mm View 2 chunks +19 lines, -3 lines 0 comments Download
M webrtc/api/objc/RTCVideoFrame.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/objctests/RTCDataChannelConfigurationTest.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/objc/RTCFileLogger.h View 2 chunks +11 lines, -6 lines 0 comments Download
M webrtc/base/objc/RTCFileLogger.mm View 5 chunks +10 lines, -10 lines 0 comments Download
M webrtc/base/objc/RTCLogging.h View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/base/objc/RTCLogging.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/build/ios/export_headers View 2 chunks +12 lines, -5 lines 0 comments Download
M webrtc/examples/objc/AppRTCDemo/ios/ARDAppDelegate.m View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
tkchin_webrtc
4 years, 8 months ago (2016-03-31 01:08:12 UTC) #5
hjon_webrtc
lgtm
4 years, 8 months ago (2016-03-31 16:36:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1845133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1845133002/40001
4 years, 8 months ago (2016-03-31 16:51:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 8 months ago (2016-03-31 19:08:07 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 19:08:20 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8b9ca953a44ce074db848734cc8b3d6138d26e93
Cr-Commit-Position: refs/heads/master@{#12183}

Powered by Google App Engine
This is Rietveld 408576698