Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: webrtc/base/bytebuffer_unittest.cc

Issue 1844803002: Modify PeerConnection for end-to-end QuicDataChannel usage (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/base/bytebuffer_unittest.cc
diff --git a/webrtc/base/bytebuffer_unittest.cc b/webrtc/base/bytebuffer_unittest.cc
index 0287d85e6f7d4ebabffc00bffeef563237c6124f..987832ca529d055375c0ffd0471279e5e384cacc 100644
--- a/webrtc/base/bytebuffer_unittest.cc
+++ b/webrtc/base/bytebuffer_unittest.cc
@@ -161,6 +161,8 @@ TEST(ByteBufferTest, TestReadWriteBuffer) {
EXPECT_EQ(wu64, ru64);
EXPECT_EQ(0U, buffer.Length());
+ // Write and read varint.
pthatcher1 2016/03/30 20:34:50 What does this mean?
mikescarlett 2016/04/05 19:58:52 This doesn't belong here, removed
+
// Write and read string.
std::string write_string("hello");
buffer.WriteString(write_string);
@@ -209,4 +211,60 @@ TEST(ByteBufferTest, TestReadWriteBuffer) {
}
}
+TEST(ByteBufferTest, TestReadWriteVarint) {
pthatcher1 2016/03/30 20:34:50 Uvarint
mikescarlett 2016/04/05 19:58:52 Done.
+ ByteBuffer write_buffer(nullptr, 0, rtc::ByteBuffer::ByteOrder::ORDER_HOST);
+ size_t size = 0;
+ EXPECT_EQ(size, write_buffer.Length());
+
+ write_buffer.WriteVarint(1u);
+ ++size;
+ EXPECT_EQ(size, write_buffer.Length());
+
+ write_buffer.WriteVarint(2u);
+ ++size;
+ EXPECT_EQ(size, write_buffer.Length());
+
+ write_buffer.WriteVarint(27u);
+ ++size;
+ EXPECT_EQ(size, write_buffer.Length());
+
+ write_buffer.WriteVarint(149u);
+ size += 2;
+ EXPECT_EQ(size, write_buffer.Length());
+
+ write_buffer.WriteVarint(68719476736u);
+ size += 6;
+ EXPECT_EQ(size, write_buffer.Length());
+
+ ByteBuffer read_buffer(write_buffer.Data(), write_buffer.Length(),
+ rtc::ByteBuffer::ByteOrder::ORDER_HOST);
pthatcher1 2016/03/30 20:34:50 Test with ORDER_NETWORK also.
mikescarlett 2016/04/05 19:58:52 Done.
+ EXPECT_EQ(size, read_buffer.Length());
+ uint64_t val1, val2, val3, val4, val5;
+
+ ASSERT_TRUE(read_buffer.ReadVarint(&val1));
+ EXPECT_EQ(1u, val1);
+ --size;
+ EXPECT_EQ(size, read_buffer.Length());
+
+ ASSERT_TRUE(read_buffer.ReadVarint(&val2));
+ EXPECT_EQ(2u, val2);
+ --size;
+ EXPECT_EQ(size, read_buffer.Length());
+
+ ASSERT_TRUE(read_buffer.ReadVarint(&val3));
+ EXPECT_EQ(27u, val3);
+ --size;
+ EXPECT_EQ(size, read_buffer.Length());
+
+ ASSERT_TRUE(read_buffer.ReadVarint(&val4));
+ EXPECT_EQ(149u, val4);
+ size -= 2;
+ EXPECT_EQ(size, read_buffer.Length());
+
+ ASSERT_TRUE(read_buffer.ReadVarint(&val5));
+ EXPECT_EQ(68719476736u, val5);
+ size -= 6;
+ EXPECT_EQ(size, read_buffer.Length());
+}
+
} // namespace rtc

Powered by Google App Engine
This is Rietveld 408576698