Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 1844503002: Fix PeerConnectionInterfaceTest.CloseAndTestStreamsAndStates (Closed)

Created:
4 years, 8 months ago by perkj_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix PeerConnectionInterfaceTest.CloseAndTestStreamsAndStates Increase delay for waiting for AudioSource state change to 10ms to hopefully fix flake that started happening on the 24th of Mars after landing https://codereview.webrtc.org/1816143002/. TBR=deadbeef@webrtc.org BUG=5692 Committed: https://crrev.com/85e46a8f1369f5518e6f853f74076f6f1a5d648e Cr-Commit-Position: refs/heads/master@{#12130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/api/peerconnectioninterface_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
perkj_webrtc
4 years, 8 months ago (2016-03-29 07:17:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/85e46a8f1369f5518e6f853f74076f6f1a5d648e Cr-Commit-Position: refs/heads/master@{#12130}
4 years, 8 months ago (2016-03-29 07:18:21 UTC) #7
perkj_webrtc
Committed patchset #1 (id:1) manually as 85e46a8f1369f5518e6f853f74076f6f1a5d648e (presubmit successful).
4 years, 8 months ago (2016-03-29 07:18:22 UTC) #8
Taylor Brandstetter
4 years, 8 months ago (2016-03-29 17:42:39 UTC) #9
Message was sent while issue was closed.
On 2016/03/29 07:18:22, perkj_webrtc wrote:
> Committed patchset #1 (id:1) manually as
> 85e46a8f1369f5518e6f853f74076f6f1a5d648e (presubmit successful).

I'd prefer making the timeout even more generous; we don't really care how quick
things happen, as long as they happen. Also, relying on the fact that only one
thread hop will occur is dangerous since that could change in the future. I
think I'll make a CL to make the new timeouts match those in the rest of the
file.

Powered by Google App Engine
This is Rietveld 408576698