Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1844333006: Add WriteUVarint to ByteBufferWriter and ReadUVarint to ByteBufferReader (Closed)

Created:
4 years, 8 months ago by mikescarlett
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add WriteUVarint to ByteBufferWriter and ReadUVarint to ByteBufferReader Methods to write/read a varint as described by https://developers.google.com/protocol-buffers/docs/encoding#varints that will be used for a QUIC data channel. Split from CL https://codereview.webrtc.org/1844803002/. Committed: https://crrev.com/9a20fa6292e3eb6ecf30aa49124ce837ff052b55 Cr-Commit-Position: refs/heads/master@{#12322}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
M webrtc/base/bytebuffer.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/base/bytebuffer.cc View 1 2 chunks +37 lines, -0 lines 0 comments Download
M webrtc/base/bytebuffer_unittest.cc View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844333006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844333006/1
4 years, 8 months ago (2016-04-02 02:01:08 UTC) #4
Taylor Brandstetter
lgtm; just noticed a minor typo. https://codereview.webrtc.org/1844333006/diff/1/webrtc/base/bytebuffer.cc File webrtc/base/bytebuffer.cc (right): https://codereview.webrtc.org/1844333006/diff/1/webrtc/base/bytebuffer.cc#newcode96 webrtc/base/bytebuffer.cc:96: // Write 7 ...
4 years, 8 months ago (2016-04-05 20:28:29 UTC) #8
mikescarlett
https://codereview.webrtc.org/1844333006/diff/1/webrtc/base/bytebuffer.cc File webrtc/base/bytebuffer.cc (right): https://codereview.webrtc.org/1844333006/diff/1/webrtc/base/bytebuffer.cc#newcode96 webrtc/base/bytebuffer.cc:96: // Write 7 bits at a time, then set ...
4 years, 8 months ago (2016-04-06 17:21:42 UTC) #9
pthatcher1
lgtm
4 years, 8 months ago (2016-04-11 21:41:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844333006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844333006/20001
4 years, 8 months ago (2016-04-11 22:04:23 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-11 23:11:43 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 23:11:53 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a20fa6292e3eb6ecf30aa49124ce837ff052b55
Cr-Commit-Position: refs/heads/master@{#12322}

Powered by Google App Engine
This is Rietveld 408576698