Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 1844313002: Rename some things SSL for style guide adherence (Closed)

Created:
4 years, 8 months ago by torbjorng (webrtc)
Modified:
4 years, 8 months ago
Reviewers:
hbos, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -23 lines) Patch
M webrtc/base/opensslidentity.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/base/opensslidentity.cc View 1 chunk +7 lines, -5 lines 2 comments Download
M webrtc/base/sslidentity.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/base/sslidentity.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M webrtc/base/sslidentity_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
torbjorng (webrtc)
PTAL, hbos.
4 years, 8 months ago (2016-03-31 12:16:56 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844313002/1
4 years, 8 months ago (2016-03-31 12:17:09 UTC) #5
hbos
lgtm
4 years, 8 months ago (2016-03-31 12:52:44 UTC) #6
hbos
On 2016/03/31 12:52:44, hbos wrote: > lgtm But update the CL description to also say ...
4 years, 8 months ago (2016-03-31 12:53:22 UTC) #7
torbjorng (webrtc)
PTAL perkj.
4 years, 8 months ago (2016-03-31 12:57:39 UTC) #10
perkj_webrtc
lgtm https://codereview.webrtc.org/1844313002/diff/1/webrtc/base/opensslidentity.cc File webrtc/base/opensslidentity.cc (right): https://codereview.webrtc.org/1844313002/diff/1/webrtc/base/opensslidentity.cc#newcode421 webrtc/base/opensslidentity.cc:421: return nullptr; RTC_CHECK(... ) ?
4 years, 8 months ago (2016-03-31 13:01:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1844313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1844313002/1
4 years, 8 months ago (2016-03-31 13:55:45 UTC) #14
torbjorng (webrtc)
https://codereview.webrtc.org/1844313002/diff/1/webrtc/base/opensslidentity.cc File webrtc/base/opensslidentity.cc (right): https://codereview.webrtc.org/1844313002/diff/1/webrtc/base/opensslidentity.cc#newcode421 webrtc/base/opensslidentity.cc:421: return nullptr; On 2016/03/31 13:01:41, perkj_webrtc wrote: > RTC_CHECK(... ...
4 years, 8 months ago (2016-03-31 13:58:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-03-31 14:17:38 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1d846b2acb1042048b4fae27701c2f7e65eb90e3 Cr-Commit-Position: refs/heads/master@{#12179}
4 years, 8 months ago (2016-03-31 14:21:23 UTC) #20
torbjorng (webrtc)
4 years, 8 months ago (2016-03-31 14:21:23 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d846b2acb1042048b4fae27701c2f7e65eb90e3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698