Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: webrtc/p2p/base/transport.cc

Issue 1844133002: Remove the dead code in Transport::ConnectChannels (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Modified the FakeTransportController Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/faketransportcontroller.h ('k') | webrtc/p2p/base/transport_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/transport.cc
diff --git a/webrtc/p2p/base/transport.cc b/webrtc/p2p/base/transport.cc
index b8d98100cf3af1f8b93b98e0362c15132ece9cd2..8d02ba4b884ab5cd420ce51fba20ee6ccf5bff3a 100644
--- a/webrtc/p2p/base/transport.cc
+++ b/webrtc/p2p/base/transport.cc
@@ -227,21 +227,7 @@ void Transport::ConnectChannels() {
connect_requested_ = true;
- if (!local_description_) {
- // TOOD(mallinath) : TransportDescription(TD) shouldn't be generated here.
- // As Transport must know TD is offer or answer and cricket::Transport
- // doesn't have the capability to decide it. This should be set by the
- // Session.
- // Session must generate local TD before remote candidates pushed when
- // initiate request initiated by the remote.
- LOG(LS_INFO) << "Transport::ConnectChannels: No local description has "
- << "been set. Will generate one.";
- TransportDescription desc(std::vector<std::string>(),
- rtc::CreateRandomString(ICE_UFRAG_LENGTH),
- rtc::CreateRandomString(ICE_PWD_LENGTH),
- ICEMODE_FULL, CONNECTIONROLE_NONE, nullptr);
- SetLocalTransportDescription(desc, CA_OFFER, nullptr);
- }
+ RTC_DCHECK(local_description_ != nullptr);
pthatcher1 2016/04/11 19:41:03 RTC_DCHECK(local_description_) is enough.
CallChannels(&TransportChannelImpl::Connect);
}
« no previous file with comments | « webrtc/p2p/base/faketransportcontroller.h ('k') | webrtc/p2p/base/transport_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698