Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: webrtc/pc/channel_unittest.cc

Issue 1842093002: Add the last_sent_packet_id to the candidate pair change signal (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Merge with head Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/channel.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/channel_unittest.cc
diff --git a/webrtc/pc/channel_unittest.cc b/webrtc/pc/channel_unittest.cc
index 9d20def32f2c60bf9b5b307c605497ed9961ad9e..a423842e00d3f2baec4788980979659736f14a35 100644
--- a/webrtc/pc/channel_unittest.cc
+++ b/webrtc/pc/channel_unittest.cc
@@ -970,7 +970,7 @@ class ChannelTest : public testing::Test, public sigslot::has_slots<> {
media_channel1_->set_num_network_route_changes(0);
// The transport channel becomes disconnected.
transport_channel1->SignalSelectedCandidatePairChanged(transport_channel1,
- nullptr);
+ nullptr, -1);
EXPECT_EQ(1, media_channel1_->num_network_route_changes());
EXPECT_FALSE(media_channel1->last_network_route().connected);
@@ -980,14 +980,18 @@ class ChannelTest : public testing::Test, public sigslot::has_slots<> {
rtc::SocketAddress remote_address("192.168.1.2", 2000 /* port number */);
uint16_t local_net_id = 1;
uint16_t remote_net_id = 2;
+ int last_packet_id = 100;
rtc::scoped_ptr<cricket::CandidatePairInterface> candidate_pair(
transport_controller1_.CreateFakeCandidatePair(
local_address, local_net_id, remote_address, remote_net_id));
transport_channel1->SignalSelectedCandidatePairChanged(
- transport_channel1, candidate_pair.get());
+ transport_channel1, candidate_pair.get(), last_packet_id);
EXPECT_EQ(1, media_channel1_->num_network_route_changes());
- cricket::NetworkRoute expected_network_route(local_net_id, remote_net_id);
+ cricket::NetworkRoute expected_network_route(local_net_id, remote_net_id,
+ last_packet_id);
EXPECT_EQ(expected_network_route, media_channel1->last_network_route());
+ EXPECT_EQ(last_packet_id,
+ media_channel1->last_network_route().last_sent_packet_id);
}
// Test setting up a call.
« no previous file with comments | « webrtc/pc/channel.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698