Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: webrtc/api/videotracksource.h

Issue 1842073002: Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool> (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 19 matching lines...) Expand all
30 // reference counted VideoTrackSource. 30 // reference counted VideoTrackSource.
31 void OnSourceDestroyed(); 31 void OnSourceDestroyed();
32 32
33 SourceState state() const override { return state_; } 33 SourceState state() const override { return state_; }
34 bool remote() const override { return remote_; } 34 bool remote() const override { return remote_; }
35 35
36 void Stop() override{}; 36 void Stop() override{};
37 void Restart() override{}; 37 void Restart() override{};
38 38
39 virtual bool is_screencast() const { return false; } 39 virtual bool is_screencast() const { return false; }
40 virtual bool needs_denoising() const { return false; } 40 virtual rtc::Optional<bool> needs_denoising() const {
41 return rtc::Optional<bool>(); }
41 42
42 void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink, 43 void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink,
43 const rtc::VideoSinkWants& wants) override; 44 const rtc::VideoSinkWants& wants) override;
44 void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override; 45 void RemoveSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override;
45 46
46 cricket::VideoCapturer* GetVideoCapturer() override { return nullptr; } 47 cricket::VideoCapturer* GetVideoCapturer() override { return nullptr; }
47 48
48 protected: 49 protected:
49 rtc::Thread* worker_thread() { return worker_thread_; } 50 rtc::Thread* worker_thread() { return worker_thread_; }
50 51
51 private: 52 private:
52 rtc::VideoSourceInterface<cricket::VideoFrame>* source_; 53 rtc::VideoSourceInterface<cricket::VideoFrame>* source_;
53 rtc::Thread* worker_thread_; 54 rtc::Thread* worker_thread_;
54 cricket::VideoOptions options_; 55 cricket::VideoOptions options_;
55 SourceState state_; 56 SourceState state_;
56 const bool remote_; 57 const bool remote_;
57 }; 58 };
58 59
59 } // namespace webrtc 60 } // namespace webrtc
60 61
61 #endif // WEBRTC_API_VIDEOTRACKSOURCE_H_ 62 #endif // WEBRTC_API_VIDEOTRACKSOURCE_H_
OLDNEW
« webrtc/api/mediastreaminterface.h ('K') | « webrtc/api/videosourceproxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698