Change VideoSourceInterface::needs_denoising() to return rtc::Optional<bool>

webrtc/api/videocapturertracksource_unittest.cc

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 316 matching lines @@
   FakeConstraints constraints;
   constraints.AddOptional("weird key", 640);
 
   CreateVideoCapturerSource(&constraints);
   EXPECT_EQ_WAIT(MediaSourceInterface::kLive, state_observer_->state(),
                  kMaxWaitMs);
 }
 
 TEST_F(VideoCapturerTrackSourceTest, SetValidDenoisingConstraint) {
   FakeConstraints constraints;
-  constraints.AddMandatory(MediaConstraintsInterface::kNoiseReduction, "true");
+  constraints.AddMandatory(MediaConstraintsInterface::kNoiseReduction, "false");
 
   CreateVideoCapturerSource(&constraints);
 
-  EXPECT_TRUE(source_->needs_denoising());
+  EXPECT_EQ(rtc::Optional<bool>(false), source_->needs_denoising());
 }
 
 TEST_F(VideoCapturerTrackSourceTest, NoiseReductionConstraintNotSet) {
   FakeConstraints constraints;
   CreateVideoCapturerSource(&constraints);
-  EXPECT_FALSE(source_->needs_denoising());
+  EXPECT_EQ(rtc::Optional<bool>(), source_->needs_denoising());
 }
 
 TEST_F(VideoCapturerTrackSourceTest,
        MandatoryDenoisingConstraintOverridesOptional) {
   FakeConstraints constraints;
   constraints.AddMandatory(MediaConstraintsInterface::kNoiseReduction, false);
   constraints.AddOptional(MediaConstraintsInterface::kNoiseReduction, true);
 
   CreateVideoCapturerSource(&constraints);
 
-  EXPECT_FALSE(source_->needs_denoising());
+  EXPECT_EQ(rtc::Optional<bool>(false), source_->needs_denoising());
 }
 
 TEST_F(VideoCapturerTrackSourceTest, NoiseReductionAndInvalidKeyOptional) {
   FakeConstraints constraints;
   constraints.AddOptional(MediaConstraintsInterface::kNoiseReduction, true);
   constraints.AddOptional("invalidKey", false);
 
   CreateVideoCapturerSource(&constraints);
 
   EXPECT_EQ_WAIT(MediaSourceInterface::kLive, state_observer_->state(),
                  kMaxWaitMs);
-  EXPECT_TRUE(source_->needs_denoising());
+  EXPECT_EQ(rtc::Optional<bool>(true), source_->needs_denoising());
 }
 
 TEST_F(VideoCapturerTrackSourceTest, NoiseReductionAndInvalidKeyMandatory) {
   FakeConstraints constraints;
   constraints.AddMandatory(MediaConstraintsInterface::kNoiseReduction, false);
   constraints.AddMandatory("invalidKey", false);
 
   CreateVideoCapturerSource(&constraints);
 
   EXPECT_EQ_WAIT(MediaSourceInterface::kEnded, state_observer_->state(),
                  kMaxWaitMs);
-  EXPECT_FALSE(source_->needs_denoising());
+  EXPECT_EQ(rtc::Optional<bool>(), source_->needs_denoising());
 }
 
 TEST_F(VideoCapturerTrackSourceTest, InvalidDenoisingValueOptional) {
   FakeConstraints constraints;
   constraints.AddOptional(MediaConstraintsInterface::kNoiseReduction,
                           "not a boolean");
 
   CreateVideoCapturerSource(&constraints);
 
   EXPECT_EQ_WAIT(MediaSourceInterface::kLive, state_observer_->state(),
                  kMaxWaitMs);
-  EXPECT_FALSE(source_->needs_denoising());
+
+  EXPECT_EQ(rtc::Optional<bool>(), source_->needs_denoising());
 }
 
 TEST_F(VideoCapturerTrackSourceTest, InvalidDenoisingValueMandatory) {
   FakeConstraints constraints;
   // Optional constraints should be ignored if the mandatory constraints fail.
   constraints.AddOptional(MediaConstraintsInterface::kNoiseReduction, "false");
   // Values are case-sensitive and must be all lower-case.
   constraints.AddMandatory(MediaConstraintsInterface::kNoiseReduction, "True");
 
   CreateVideoCapturerSource(&constraints);
 
   EXPECT_EQ_WAIT(MediaSourceInterface::kEnded, state_observer_->state(),
                  kMaxWaitMs);
-  EXPECT_FALSE(source_->needs_denoising());
+  EXPECT_EQ(rtc::Optional<bool>(), source_->needs_denoising());
 }
 
 TEST_F(VideoCapturerTrackSourceTest, MixedOptionsAndConstraints) {
   FakeConstraints constraints;
   constraints.AddMandatory(MediaConstraintsInterface::kMaxWidth, 352);
   constraints.AddMandatory(MediaConstraintsInterface::kMaxHeight, 288);
   constraints.AddOptional(MediaConstraintsInterface::kMaxFrameRate, 5);
 
   constraints.AddMandatory(MediaConstraintsInterface::kNoiseReduction, false);
   constraints.AddOptional(MediaConstraintsInterface::kNoiseReduction, true);
 
   CreateVideoCapturerSource(&constraints);
   EXPECT_EQ_WAIT(MediaSourceInterface::kLive, state_observer_->state(),
                  kMaxWaitMs);
   const cricket::VideoFormat* format = capturer_->GetCaptureFormat();
   ASSERT_TRUE(format != NULL);
   EXPECT_EQ(352, format->width);
   EXPECT_EQ(288, format->height);
   EXPECT_EQ(30, format->framerate());
 
-  EXPECT_FALSE(source_->needs_denoising());
+  EXPECT_EQ(rtc::Optional<bool>(false), source_->needs_denoising());
 }
 
 // Tests that the source starts video with the default resolution for
 // screencast if no constraint is set.
 TEST_F(VideoCapturerTrackSourceTest, ScreencastResolutionNoConstraint) {
   InitScreencast();
   capturer_->TestWithoutCameraFormats();
 
   CreateVideoCapturerSource();
   ASSERT_TRUE(source_->is_screencast());
@@ skipping 41 matching lines @@
   FakeConstraints constraints;
   constraints.AddOptional(MediaConstraintsInterface::kMaxFrameRate, 0.5);
 
   CreateVideoCapturerSource(&constraints);
   EXPECT_EQ_WAIT(MediaSourceInterface::kLive, state_observer_->state(),
                  kMaxWaitMs);
   const cricket::VideoFormat* format = capturer_->GetCaptureFormat();
   ASSERT_TRUE(format != NULL);
   EXPECT_EQ(30, format->framerate());
 }