Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1842003003: Removed unused code and simplified the code for the AEC metrics (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
minyue-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed unused code and simplified the code for the AEC metrics BUG= Committed: https://crrev.com/fc3ef3e5c114117005dbaf030f95bc9e5a6a2cc5 Cr-Commit-Position: refs/heads/master@{#12258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M webrtc/modules/audio_processing/aec/aec_core.cc View 4 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
peah-webrtc
4 years, 8 months ago (2016-03-30 21:29:24 UTC) #2
minyue-webrtc
lgtm
4 years, 8 months ago (2016-04-05 12:30:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842003003/1
4 years, 8 months ago (2016-04-05 13:36:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-05 15:36:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1842003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1842003003/1
4 years, 8 months ago (2016-04-06 09:26:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-06 09:28:29 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 09:28:41 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fc3ef3e5c114117005dbaf030f95bc9e5a6a2cc5
Cr-Commit-Position: refs/heads/master@{#12258}

Powered by Google App Engine
This is Rietveld 408576698