Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1841363002: Changed the names of some of the bitexactness unittests to be similar to the other test file names (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changed the names of some of the bitexactness unittests to be similar to the other file names of the tests. (Also removed a redundant blank line in the highpass filter unittest file). BUG= Committed: https://crrev.com/9846651cc4d08fd5b707b0713f4c4868313af6a2 Cr-Commit-Position: refs/heads/master@{#12171}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1041 lines) Patch
D webrtc/modules/audio_processing/high_pass_filter_bitexactness_unittest.cc View 1 chunk +0 lines, -686 lines 0 comments Download
A + webrtc/modules/audio_processing/high_pass_filter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/audio_processing/level_estimator_bitexactness_unittest.cc View 1 chunk +0 lines, -93 lines 0 comments Download
A + webrtc/modules/audio_processing/level_estimator_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/modules/audio_processing/noise_suppression_bitexactness_unittest.cc View 1 chunk +0 lines, -260 lines 0 comments Download
A + webrtc/modules/audio_processing/noise_suppression_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
peah-webrtc
4 years, 8 months ago (2016-03-30 04:26:39 UTC) #3
hlundin-webrtc
lgtm
4 years, 8 months ago (2016-03-30 08:22:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841363002/1
4 years, 8 months ago (2016-03-30 16:15:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 8 months ago (2016-03-30 18:15:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841363002/1
4 years, 8 months ago (2016-03-30 18:33:41 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-03-30 20:34:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1841363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1841363002/1
4 years, 8 months ago (2016-03-30 21:12:14 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 22:33:57 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 22:34:07 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9846651cc4d08fd5b707b0713f4c4868313af6a2
Cr-Commit-Position: refs/heads/master@{#12171}

Powered by Google App Engine
This is Rietveld 408576698