Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1840893004: Reland https://codereview.webrtc.org/1802993002/ (Closed)

Created:
4 years, 8 months ago by the sun
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, danilchap, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland https://codereview.webrtc.org/1802993002/ Clean away use of RtpAudioFeedback interface from RTP/RTCP receiver code. BUG=webrtc:4690 Committed: https://crrev.com/69a81999ace08e40e2b2ec526b0e111aa11b9538 Cr-Commit-Position: refs/heads/master@{#12015} Committed: https://crrev.com/1d0313916b5ce2059a51de0530df85998a4054e9 Cr-Commit-Position: refs/heads/master@{#12157}

Patch Set 1 #

Patch Set 2 : Reanimate CreateAudioReceiver() with 5 params, to not break downstream code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -63 lines) Patch
M webrtc/modules/rtp_rtcp/include/rtp_receiver.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h View 2 chunks +0 lines, -20 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_audio.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_impl.cc View 1 2 chunks +16 lines, -11 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_receiver_strategy.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_utility.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_rtcp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
the sun
4 years, 8 months ago (2016-03-29 13:22:22 UTC) #2
hlundin-webrtc
lgtm
4 years, 8 months ago (2016-03-29 21:26:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1840893004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1840893004/20001
4 years, 8 months ago (2016-03-30 07:51:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 09:42:37 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 09:42:42 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1d0313916b5ce2059a51de0530df85998a4054e9
Cr-Commit-Position: refs/heads/master@{#12157}

Powered by Google App Engine
This is Rietveld 408576698