Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Issue 1839803006: Signal ready-to-send when switching to a writable connection. (Closed)

Created:
4 years, 8 months ago by honghaiz3
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Signal ready-to-send when switching to a writable connection. BUG=webrtc:5705 R=pthatcher@webrtc.org Committed: https://crrev.com/82f132c90acf79790df4dd2ac9142826309aa362 Cr-Commit-Position: refs/heads/master@{#12168}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M webrtc/p2p/base/p2ptransportchannel.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 7 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
honghaiz3
4 years, 8 months ago (2016-03-30 16:20:24 UTC) #3
pthatcher1
lgtm
4 years, 8 months ago (2016-03-30 17:04:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839803006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839803006/20001
4 years, 8 months ago (2016-03-30 18:20:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 8 months ago (2016-03-30 18:42:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839803006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839803006/20001
4 years, 8 months ago (2016-03-30 19:52:46 UTC) #10
honghaiz3
Committed patchset #1 (id:20001) manually as 82f132c90acf79790df4dd2ac9142826309aa362 (presubmit successful).
4 years, 8 months ago (2016-03-30 19:55:31 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 20:05:05 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82f132c90acf79790df4dd2ac9142826309aa362
Cr-Commit-Position: refs/heads/master@{#12168}

Powered by Google App Engine
This is Rietveld 408576698