Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1839763004: Remove {media,p2p,pc,xmllite,xmpp}_tests.gypi files. (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove {media,p2p,pc,xmllite,xmpp}_tests.gypi files. These contributes to circular dependency problems in WebRTC since one have to depend on webrtc.gyp in order to depend on a target in them. This reduces the number of cyclic dependencies in WebRTC from 21 to 16. BUG=webrtc:4243 NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/231b69f28dd22f4e2d98e5048f8eaae7b20915e6 Cr-Commit-Position: refs/heads/master@{#12166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -440 lines) Patch
M webrtc/api/api_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/libjingle/xmllite/xmllite.gyp View 1 chunk +21 lines, -1 line 0 comments Download
D webrtc/libjingle/xmllite/xmllite_tests.gypi View 1 chunk +0 lines, -28 lines 0 comments Download
M webrtc/libjingle/xmpp/xmpp.gyp View 1 chunk +31 lines, -1 line 0 comments Download
D webrtc/libjingle/xmpp/xmpp_tests.gypi View 1 chunk +0 lines, -37 lines 0 comments Download
M webrtc/media/media.gyp View 1 chunk +184 lines, -0 lines 0 comments Download
D webrtc/media/media_tests.gypi View 1 chunk +0 lines, -174 lines 0 comments Download
A + webrtc/media/rtc_media_unittests.isolate View 0 chunks +-1 lines, --1 lines 0 comments Download
M webrtc/p2p/p2p.gyp View 1 chunk +47 lines, -1 line 0 comments Download
D webrtc/p2p/p2p_tests.gypi View 1 chunk +0 lines, -53 lines 0 comments Download
M webrtc/pc/pc.gyp View 1 chunk +72 lines, -1 line 0 comments Download
D webrtc/pc/pc_tests.gypi View 1 chunk +0 lines, -61 lines 0 comments Download
A + webrtc/pc/rtc_pc_unittests.isolate View 0 chunks +-1 lines, --1 lines 0 comments Download
D webrtc/rtc_media_unittests.isolate View 1 chunk +0 lines, -28 lines 0 comments Download
D webrtc/rtc_pc_unittests.isolate View 1 chunk +0 lines, -22 lines 0 comments Download
M webrtc/webrtc.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 2 chunks +3 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_webrtc
4 years, 8 months ago (2016-03-29 20:40:26 UTC) #3
pthatcher1
lgtm
4 years, 8 months ago (2016-03-30 16:37:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1839763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1839763004/1
4 years, 8 months ago (2016-03-30 18:40:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-30 18:40:37 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/231b69f28dd22f4e2d98e5048f8eaae7b20915e6 Cr-Commit-Position: refs/heads/master@{#12166}
4 years, 8 months ago (2016-03-30 18:40:42 UTC) #11
kjellander_webrtc
4 years, 8 months ago (2016-03-30 18:53:52 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1846693002/ by kjellander@webrtc.org.

The reason for reverting is: Breaks Chromium:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Mac%20Builder/build...:

Updating projects from gyp files...
Using overrides found in /Users/chrome-bot/.gyp/include.gypi
Traceback (most recent call last):
  File "src/build/gyp_chromium", line 12, in <module>
    execfile(__file__ + '.py')
  File "src/build/gyp_chromium.py", line 341, in <module>
    sys.exit(main())
  File "src/build/gyp_chromium.py", line 328, in main
    gyp_rc = gyp.main(args)
  File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/__init__.py",
line 538, in main
    return gyp_main(args)
  File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/__init__.py",
line 514, in gyp_main
    options.duplicate_basename_check)
  File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/__init__.py",
line 130, in Load
    params['parallel'], params['root_targets'])
  File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/input.py", line
2800, in Load
    RemoveLinkDependenciesFromNoneTargets(targets)
  File "/b/build/slave/Mac_Builder/build/src/tools/gyp/pylib/gyp/input.py", line
1510, in RemoveLinkDependenciesFromNoneTargets
    if targets[t].get('variables', {}).get('link_dependency', 0):
KeyError:
'/b/build/slave/Mac_Builder/build/src/third_party/webrtc/media/media.gyp:rtc_media_unittests#target'
Error: Command '/usr/bin/python src/build/gyp_chromium' returned non-zero exit
status 1 in /b/build/slave/Mac_Builder/build
Hook '/usr/bin/python src/build/gyp_chromium' took 20.29 secs

.

Powered by Google App Engine
This is Rietveld 408576698