Improve iOS frame capture threading.

Improve iOS frame capture threading.

- Posts to WebRTC thread instead of Send
- Sample buffers are returned on capture session queue instead of main queue
- Camera switch happens on captures session queue

BUG=webrtc:5679, webrtc:4212
Committed: https://crrev.com/89717aad5099d7cf5ff55dd5eace6df6651de3c7
Cr-Commit-Position: refs/heads/master@{#12186}

[tkchin_webrtc, 2016-03-30 01:38:35]

Description was changed from

==========
Improve capture frame threading.

BUG=
==========

to

==========
Improve capture frame threading.

BUG=webrtc:5679, webrtc:4212
==========

[tkchin_webrtc, 2016-03-30 01:38:35]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org

[tkchin_webrtc, 2016-03-30 22:48:46]

Patchset #1 (id:1) has been deleted

[tkchin_webrtc, 2016-03-30 22:48:51]

Patchset #1 (id:20001) has been deleted

[tkchin_webrtc, 2016-03-30 22:48:56]

Patchset #1 (id:40001) has been deleted

[tkchin_webrtc, 2016-03-30 22:50:20]

Description was changed from

==========
Improve capture frame threading.

BUG=webrtc:5679, webrtc:4212
==========

to

==========
Improve iOS frame capture threading.

- Posts to WebRTC thread instead of Send
- Sample buffers are returned on capture session queue instead of main queue
- Camera switch happens on captures session queue

BUG=webrtc:5679, webrtc:4212
==========

[Chuck, 2016-03-31 19:20:38]

Just formatting nits, same nits apply to both copies but I didn't duplicate
them.

LGTM

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
File talk/app/webrtc/objc/avfoundationvideocapturer.mm (right):

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:42: static NSString* const
kDefaultPreset = AVCaptureSessionPreset640x480;
nit: If you are cleaning up spacing around *, here is another

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:164: [self updateOrientation];
I don't think it matters, but this is a strong reference to self in the block
(and below).

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:457: AVCaptureSession*
AVFoundationVideoCapturer::GetCaptureSession() {
nit: another

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:520: uint8_t* y_plane_address
=
nit: There are a few "* " here instead of " *"

[tkchin_webrtc, 2016-03-31 20:50:08]

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
File talk/app/webrtc/objc/avfoundationvideocapturer.mm (right):

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:42: static NSString* const
kDefaultPreset = AVCaptureSessionPreset640x480;
On 2016/03/31 19:20:37, Chuck wrote:
> nit: If you are cleaning up spacing around *, here is another

Done.

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:164: [self updateOrientation];
On 2016/03/31 19:20:37, Chuck wrote:
> I don't think it matters, but this is a strong reference to self in the block
> (and below).

Starting to move to a model where we don't bother with weak/strong unless we
absolutely have to. Makes reasoning about blocks easier.

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:457: AVCaptureSession*
AVFoundationVideoCapturer::GetCaptureSession() {
On 2016/03/31 19:20:37, Chuck wrote:
> nit: another

the rule is C++ style rules for C++ code and ObjC rules for ObjC code

https://codereview.webrtc.org/1838933004/diff/60001/talk/app/webrtc/objc/avfo...
talk/app/webrtc/objc/avfoundationvideocapturer.mm:520: uint8_t* y_plane_address
=
On 2016/03/31 19:20:37, Chuck wrote:
> nit: There are a few "* " here instead of " *"

Acknowledged.

[tkchin_webrtc, 2016-03-31 21:16:38]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-03-31 21:16:39]

The patchset sent to the CQ was uploaded after l-g-t-m from haysc@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1838933004/#ps80001 (title:
"Fix *")

[commit-bot: I haz the power, 2016-03-31 21:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838933004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838933004/80001

[commit-bot: I haz the power, 2016-03-31 22:50:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 22:50:34]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[tkchin_webrtc, 2016-03-31 23:27:47]

The CQ bit was checked by tkchin@webrtc.org

[commit-bot: I haz the power, 2016-03-31 23:28:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838933004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838933004/80001

[commit-bot: I haz the power, 2016-04-01 00:14:07]

Description was changed from

==========
Improve iOS frame capture threading.

- Posts to WebRTC thread instead of Send
- Sample buffers are returned on capture session queue instead of main queue
- Camera switch happens on captures session queue

BUG=webrtc:5679, webrtc:4212
==========

to

==========
Improve iOS frame capture threading.

- Posts to WebRTC thread instead of Send
- Sample buffers are returned on capture session queue instead of main queue
- Camera switch happens on captures session queue

BUG=webrtc:5679, webrtc:4212
==========

[commit-bot: I haz the power, 2016-04-01 00:14:09]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-04-01 00:14:14]

Description was changed from

==========
Improve iOS frame capture threading.

- Posts to WebRTC thread instead of Send
- Sample buffers are returned on capture session queue instead of main queue
- Camera switch happens on captures session queue

BUG=webrtc:5679, webrtc:4212
==========

to

==========
Improve iOS frame capture threading.

- Posts to WebRTC thread instead of Send
- Sample buffers are returned on capture session queue instead of main queue
- Camera switch happens on captures session queue

BUG=webrtc:5679, webrtc:4212

Committed: https://crrev.com/89717aad5099d7cf5ff55dd5eace6df6651de3c7
Cr-Commit-Position: refs/heads/master@{#12186}
==========

[commit-bot: I haz the power, 2016-04-01 00:14:15]

Patchset 2 (id:??) landed as
https://crrev.com/89717aad5099d7cf5ff55dd5eace6df6651de3c7
Cr-Commit-Position: refs/heads/master@{#12186}