Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: webrtc/pc/channel.cc

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressing pbos@'s comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/pc/channel.cc
diff --git a/webrtc/pc/channel.cc b/webrtc/pc/channel.cc
index 7e4d5d2dac1e9596566fc591ef992519616f8594..3190e98a606b27a73cc7b6d4711b70d18a9b7b09 100644
--- a/webrtc/pc/channel.cc
+++ b/webrtc/pc/channel.cc
@@ -1807,18 +1807,13 @@ bool VideoChannel::SetSink(uint32_t ssrc,
return true;
}
-void VideoChannel::SetSource(
+bool VideoChannel::SetVideoSend(
uint32_t ssrc,
+ bool mute,
+ const VideoOptions* options,
rtc::VideoSourceInterface<cricket::VideoFrame>* source) {
- worker_thread()->Invoke<void>(
- Bind(&VideoMediaChannel::SetSource, media_channel(), ssrc, source));
-}
-
-bool VideoChannel::SetVideoSend(uint32_t ssrc,
- bool mute,
- const VideoOptions* options) {
return InvokeOnWorker(Bind(&VideoMediaChannel::SetVideoSend, media_channel(),
- ssrc, mute, options));
+ ssrc, mute, options, source));
}
webrtc::RtpParameters VideoChannel::GetRtpParameters(uint32_t ssrc) const {

Powered by Google App Engine
This is Rietveld 408576698