Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressing pbos@'s comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvideoengine2.h
diff --git a/webrtc/media/engine/webrtcvideoengine2.h b/webrtc/media/engine/webrtcvideoengine2.h
index e9b96f951e99152729afe13d739e3d761620dd64..a082147dc1595fe80269e66615d839483706a425 100644
--- a/webrtc/media/engine/webrtcvideoengine2.h
+++ b/webrtc/media/engine/webrtcvideoengine2.h
@@ -152,9 +152,11 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {
const webrtc::RtpParameters& parameters) override;
bool GetSendCodec(VideoCodec* send_codec) override;
bool SetSend(bool send) override;
- bool SetVideoSend(uint32_t ssrc,
- bool mute,
- const VideoOptions* options) override;
+ bool SetVideoSend(
+ uint32_t ssrc,
+ bool enable,
+ const VideoOptions* options,
+ rtc::VideoSourceInterface<cricket::VideoFrame>* source) override;
bool AddSendStream(const StreamParams& sp) override;
bool RemoveSendStream(uint32_t ssrc) override;
bool AddRecvStream(const StreamParams& sp) override;
@@ -163,9 +165,6 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {
bool SetSink(uint32_t ssrc,
rtc::VideoSinkInterface<VideoFrame>* sink) override;
bool GetStats(VideoMediaInfo* info) override;
- void SetSource(
- uint32_t ssrc,
- rtc::VideoSourceInterface<cricket::VideoFrame>* source) override;
void OnPacketReceived(rtc::CopyOnWriteBuffer* packet,
const rtc::PacketTime& packet_time) override;
@@ -222,7 +221,6 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {
ChangedRecvParameters* changed_params) const;
void SetMaxSendBandwidth(int bps);
- void SetOptions(uint32_t ssrc, const VideoOptions& options);
void ConfigureReceiverRtp(webrtc::VideoReceiveStream::Config* config,
const StreamParams& sp) const;
@@ -256,14 +254,14 @@ class WebRtcVideoChannel2 : public VideoMediaChannel, public webrtc::Transport {
const VideoSendParameters& send_params);
virtual ~WebRtcVideoSendStream();
- void SetOptions(const VideoOptions& options);
- // TODO(pbos): Move logic from SetOptions into this method.
void SetSendParameters(const ChangedSendParameters& send_params);
bool SetRtpParameters(const webrtc::RtpParameters& parameters);
webrtc::RtpParameters GetRtpParameters() const;
void OnFrame(const cricket::VideoFrame& frame) override;
- void SetSource(rtc::VideoSourceInterface<cricket::VideoFrame>* source);
+ bool SetVideoSend(bool mute,
+ const VideoOptions* options,
+ rtc::VideoSourceInterface<cricket::VideoFrame>* source);
void DisconnectSource();
void SetSend(bool send);

Powered by Google App Engine
This is Rietveld 408576698