webrtc/api/webrtcsession.h - Issue 1838413002: Combining SetVideoSend and SetSource into one method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/webrtcsession.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressing pbos@'s comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/webrtcsession.h

diff --git a/webrtc/api/webrtcsession.h b/webrtc/api/webrtcsession.h

index 8a32d78f5eda19185d1851b497e0e8bffc3e774e..6b2cad06f3d580107ea20ad8ced4066271065df4 100644

--- a/webrtc/api/webrtcsession.h

+++ b/webrtc/api/webrtcsession.h

@@ -248,16 +248,15 @@ class WebRtcSession : public AudioProviderInterface,

const RtpParameters& parameters) override;

// Implements VideoMediaProviderInterface.

- bool SetSource(

- uint32_t ssrc,

- rtc::VideoSourceInterface<cricket::VideoFrame>* source) override;

void SetVideoPlayout(

uint32_t ssrc,

bool enable,

rtc::VideoSinkInterface<cricket::VideoFrame>* sink) override;

- void SetVideoSend(uint32_t ssrc,

- bool enable,

- const cricket::VideoOptions* options) override;

+ void SetVideoSend(

+ uint32_t ssrc,

+ bool enable,

+ const cricket::VideoOptions* options,

+ rtc::VideoSourceInterface<cricket::VideoFrame>* source) override;

RtpParameters GetVideoRtpParameters(uint32_t ssrc) const override;

bool SetVideoRtpParameters(uint32_t ssrc,

« webrtc/api/rtpsender.cc ('K') | « webrtc/api/rtpsenderreceiver_unittest.cc ('k') | webrtc/api/webrtcsession.cc » ('j') | webrtc/media/engine/webrtcvideoengine2.cc » ('J')