webrtc/api/webrtcsession_unittest.cc - Issue 1838413002: Combining SetVideoSend and SetSource into one method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/webrtcsession_unittest.cc

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Adding TODO. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/webrtcsession_unittest.cc

diff --git a/webrtc/api/webrtcsession_unittest.cc b/webrtc/api/webrtcsession_unittest.cc

index f2ac38c4380b0dc7e226f7c80bd87cdfef789223..088694cb16b6a07c5be0276be63e9423cf45e02c 100644

--- a/webrtc/api/webrtcsession_unittest.cc

+++ b/webrtc/api/webrtcsession_unittest.cc

@@ -253,7 +253,6 @@ class WebRtcSessionForTest : public webrtc::WebRtcSession {

using webrtc::WebRtcSession::SetAudioPlayout;

using webrtc::WebRtcSession::SetAudioSend;

- using webrtc::WebRtcSession::SetSource;

using webrtc::WebRtcSession::SetVideoPlayout;

using webrtc::WebRtcSession::SetVideoSend;

@@ -3540,9 +3539,9 @@ TEST_F(WebRtcSessionTest, SetVideoSend) {

uint32_t send_ssrc = channel->send_streams()[0].first_ssrc();

EXPECT_FALSE(channel->IsStreamMuted(send_ssrc));

cricket::VideoOptions* options = NULL;

- session_->SetVideoSend(send_ssrc, false, options);

+ session_->SetVideoSend(send_ssrc, false, options, nullptr);

EXPECT_TRUE(channel->IsStreamMuted(send_ssrc));

- session_->SetVideoSend(send_ssrc, true, options);

+ session_->SetVideoSend(send_ssrc, true, options, nullptr);

EXPECT_FALSE(channel->IsStreamMuted(send_ssrc));

}

« no previous file with comments | « webrtc/api/webrtcsession.cc ('k') | webrtc/media/base/fakemediaengine.h » ('j') | no next file with comments »