Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: webrtc/api/mediastreamprovider.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressing pbos@'s comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/api/rtpsender.cc » ('j') | webrtc/api/rtpsender.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 const RtpParameters& parameters) = 0; 69 const RtpParameters& parameters) = 0;
70 70
71 protected: 71 protected:
72 virtual ~AudioProviderInterface() {} 72 virtual ~AudioProviderInterface() {}
73 }; 73 };
74 74
75 // This interface is called by VideoRtpSender/Receivers to change the settings 75 // This interface is called by VideoRtpSender/Receivers to change the settings
76 // of a video track connected to a certain PeerConnection. 76 // of a video track connected to a certain PeerConnection.
77 class VideoProviderInterface { 77 class VideoProviderInterface {
78 public: 78 public:
79 virtual bool SetSource(
80 uint32_t ssrc,
81 rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
82 // Enable/disable the video playout of a remote video track with |ssrc|. 79 // Enable/disable the video playout of a remote video track with |ssrc|.
83 virtual void SetVideoPlayout( 80 virtual void SetVideoPlayout(
84 uint32_t ssrc, 81 uint32_t ssrc,
85 bool enable, 82 bool enable,
86 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0; 83 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0;
87 // Enable sending video on the local video track with |ssrc|. 84 // Enable/disable sending video on the local video track with |ssrc|.
88 virtual void SetVideoSend(uint32_t ssrc, 85 // TODO(deadbeef): Make |options| a reference parameter.
89 bool enable, 86 virtual void SetVideoSend(
90 const cricket::VideoOptions* options) = 0; 87 uint32_t ssrc,
88 bool enable,
89 const cricket::VideoOptions* options,
90 rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
91 91
92 virtual RtpParameters GetVideoRtpParameters(uint32_t ssrc) const = 0; 92 virtual RtpParameters GetVideoRtpParameters(uint32_t ssrc) const = 0;
93 virtual bool SetVideoRtpParameters(uint32_t ssrc, 93 virtual bool SetVideoRtpParameters(uint32_t ssrc,
94 const RtpParameters& parameters) = 0; 94 const RtpParameters& parameters) = 0;
95 95
96 protected: 96 protected:
97 virtual ~VideoProviderInterface() {} 97 virtual ~VideoProviderInterface() {}
98 }; 98 };
99 99
100 } // namespace webrtc 100 } // namespace webrtc
101 101
102 #endif // WEBRTC_API_MEDIASTREAMPROVIDER_H_ 102 #endif // WEBRTC_API_MEDIASTREAMPROVIDER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/api/rtpsender.cc » ('j') | webrtc/api/rtpsender.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698