Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: webrtc/pc/channel.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing comments and other minor things Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 471 matching lines...) Expand 10 before | Expand all | Expand 10 after
482 bool rtcp); 482 bool rtcp);
483 ~VideoChannel(); 483 ~VideoChannel();
484 bool Init_w(); 484 bool Init_w();
485 485
486 // downcasts a MediaChannel 486 // downcasts a MediaChannel
487 VideoMediaChannel* media_channel() const override { 487 VideoMediaChannel* media_channel() const override {
488 return static_cast<VideoMediaChannel*>(BaseChannel::media_channel()); 488 return static_cast<VideoMediaChannel*>(BaseChannel::media_channel());
489 } 489 }
490 490
491 bool SetSink(uint32_t ssrc, rtc::VideoSinkInterface<VideoFrame>* sink); 491 bool SetSink(uint32_t ssrc, rtc::VideoSinkInterface<VideoFrame>* sink);
492 // Register a source. The |ssrc| must correspond to a registered
493 // send stream.
494 void SetSource(uint32_t ssrc, 492 void SetSource(uint32_t ssrc,
495 rtc::VideoSourceInterface<cricket::VideoFrame>* source); 493 rtc::VideoSourceInterface<cricket::VideoFrame>* source);
496 // Get statistics about the current media session. 494 // Get statistics about the current media session.
497 bool GetStats(VideoMediaInfo* stats); 495 bool GetStats(VideoMediaInfo* stats);
498 496
499 sigslot::signal2<VideoChannel*, const std::vector<ConnectionInfo>&> 497 sigslot::signal2<VideoChannel*, const std::vector<ConnectionInfo>&>
500 SignalConnectionMonitor; 498 SignalConnectionMonitor;
501 499
502 void StartMediaMonitor(int cms); 500 void StartMediaMonitor(int cms);
503 void StopMediaMonitor(); 501 void StopMediaMonitor();
504 sigslot::signal2<VideoChannel*, const VideoMediaInfo&> SignalMediaMonitor; 502 sigslot::signal2<VideoChannel*, const VideoMediaInfo&> SignalMediaMonitor;
505 503
506 bool SetVideoSend(uint32_t ssrc, bool enable, const VideoOptions* options); 504 // Register a source and set options.
505 // The |ssrc| must correspond to a registered send stream.
506 bool SetVideoSend(uint32_t ssrc,
507 bool enable,
508 const VideoOptions* options,
509 rtc::VideoSourceInterface<cricket::VideoFrame>* source);
507 webrtc::RtpParameters GetRtpParameters(uint32_t ssrc) const; 510 webrtc::RtpParameters GetRtpParameters(uint32_t ssrc) const;
508 bool SetRtpParameters(uint32_t ssrc, const webrtc::RtpParameters& parameters); 511 bool SetRtpParameters(uint32_t ssrc, const webrtc::RtpParameters& parameters);
509 512
510 private: 513 private:
511 // overrides from BaseChannel 514 // overrides from BaseChannel
512 void ChangeState_w() override; 515 void ChangeState_w() override;
513 const ContentInfo* GetFirstContent(const SessionDescription* sdesc) override; 516 const ContentInfo* GetFirstContent(const SessionDescription* sdesc) override;
514 bool SetLocalContent_w(const MediaContentDescription* content, 517 bool SetLocalContent_w(const MediaContentDescription* content,
515 ContentAction action, 518 ContentAction action,
516 std::string* error_desc) override; 519 std::string* error_desc) override;
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
657 // SetSendParameters. 660 // SetSendParameters.
658 DataSendParameters last_send_params_; 661 DataSendParameters last_send_params_;
659 // Last DataRecvParameters sent down to the media_channel() via 662 // Last DataRecvParameters sent down to the media_channel() via
660 // SetRecvParameters. 663 // SetRecvParameters.
661 DataRecvParameters last_recv_params_; 664 DataRecvParameters last_recv_params_;
662 }; 665 };
663 666
664 } // namespace cricket 667 } // namespace cricket
665 668
666 #endif // WEBRTC_PC_CHANNEL_H_ 669 #endif // WEBRTC_PC_CHANNEL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698