Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Side by Side Diff: webrtc/media/base/mediachannel.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing comments and other minor things Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 975 matching lines...) Expand 10 before | Expand all | Expand 10 after
986 986
987 virtual bool SetSendParameters(const VideoSendParameters& params) = 0; 987 virtual bool SetSendParameters(const VideoSendParameters& params) = 0;
988 virtual bool SetRecvParameters(const VideoRecvParameters& params) = 0; 988 virtual bool SetRecvParameters(const VideoRecvParameters& params) = 0;
989 virtual webrtc::RtpParameters GetRtpParameters(uint32_t ssrc) const = 0; 989 virtual webrtc::RtpParameters GetRtpParameters(uint32_t ssrc) const = 0;
990 virtual bool SetRtpParameters(uint32_t ssrc, 990 virtual bool SetRtpParameters(uint32_t ssrc,
991 const webrtc::RtpParameters& parameters) = 0; 991 const webrtc::RtpParameters& parameters) = 0;
992 // Gets the currently set codecs/payload types to be used for outgoing media. 992 // Gets the currently set codecs/payload types to be used for outgoing media.
993 virtual bool GetSendCodec(VideoCodec* send_codec) = 0; 993 virtual bool GetSendCodec(VideoCodec* send_codec) = 0;
994 // Starts or stops transmission (and potentially capture) of local video. 994 // Starts or stops transmission (and potentially capture) of local video.
995 virtual bool SetSend(bool send) = 0; 995 virtual bool SetSend(bool send) = 0;
996 // Configure stream for sending. 996 // Configure stream for sending and register a source.
997 virtual bool SetVideoSend(uint32_t ssrc, 997 // The |ssrc| must correspond to a registered send stream.
998 bool enable, 998 virtual bool SetVideoSend(
999 const VideoOptions* options) = 0; 999 uint32_t ssrc,
1000 bool enable,
1001 const VideoOptions* options,
1002 rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
1000 // Sets the sink object to be used for the specified stream. 1003 // Sets the sink object to be used for the specified stream.
1001 // If SSRC is 0, the renderer is used for the 'default' stream. 1004 // If SSRC is 0, the renderer is used for the 'default' stream.
1002 virtual bool SetSink(uint32_t ssrc, 1005 virtual bool SetSink(uint32_t ssrc,
1003 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0; 1006 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0;
1004 // Register a source. The |ssrc| must correspond to a registered send stream.
1005 virtual void SetSource(
1006 uint32_t ssrc,
1007 rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
1008 // Gets quality stats for the channel. 1007 // Gets quality stats for the channel.
1009 virtual bool GetStats(VideoMediaInfo* info) = 0; 1008 virtual bool GetStats(VideoMediaInfo* info) = 0;
1010 }; 1009 };
1011 1010
1012 enum DataMessageType { 1011 enum DataMessageType {
1013 // Chrome-Internal use only. See SctpDataMediaChannel for the actual PPID 1012 // Chrome-Internal use only. See SctpDataMediaChannel for the actual PPID
1014 // values. 1013 // values.
1015 DMT_NONE = 0, 1014 DMT_NONE = 0,
1016 DMT_CONTROL = 1, 1015 DMT_CONTROL = 1,
1017 DMT_BINARY = 2, 1016 DMT_BINARY = 2,
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1127 // Signal when the media channel is ready to send the stream. Arguments are: 1126 // Signal when the media channel is ready to send the stream. Arguments are:
1128 // writable(bool) 1127 // writable(bool)
1129 sigslot::signal1<bool> SignalReadyToSend; 1128 sigslot::signal1<bool> SignalReadyToSend;
1130 // Signal for notifying that the remote side has closed the DataChannel. 1129 // Signal for notifying that the remote side has closed the DataChannel.
1131 sigslot::signal1<uint32_t> SignalStreamClosedRemotely; 1130 sigslot::signal1<uint32_t> SignalStreamClosedRemotely;
1132 }; 1131 };
1133 1132
1134 } // namespace cricket 1133 } // namespace cricket
1135 1134
1136 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_ 1135 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698