Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: webrtc/pc/channel.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding TODO. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2_unittest.cc ('k') | webrtc/pc/channel.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 bool rtcp); 490 bool rtcp);
491 ~VideoChannel(); 491 ~VideoChannel();
492 bool Init_w(const std::string* bundle_transport_name); 492 bool Init_w(const std::string* bundle_transport_name);
493 493
494 // downcasts a MediaChannel 494 // downcasts a MediaChannel
495 VideoMediaChannel* media_channel() const override { 495 VideoMediaChannel* media_channel() const override {
496 return static_cast<VideoMediaChannel*>(BaseChannel::media_channel()); 496 return static_cast<VideoMediaChannel*>(BaseChannel::media_channel());
497 } 497 }
498 498
499 bool SetSink(uint32_t ssrc, rtc::VideoSinkInterface<VideoFrame>* sink); 499 bool SetSink(uint32_t ssrc, rtc::VideoSinkInterface<VideoFrame>* sink);
500 // Register a source. The |ssrc| must correspond to a registered
501 // send stream.
502 void SetSource(uint32_t ssrc, 500 void SetSource(uint32_t ssrc,
503 rtc::VideoSourceInterface<cricket::VideoFrame>* source); 501 rtc::VideoSourceInterface<cricket::VideoFrame>* source);
504 // Get statistics about the current media session. 502 // Get statistics about the current media session.
505 bool GetStats(VideoMediaInfo* stats); 503 bool GetStats(VideoMediaInfo* stats);
506 504
507 sigslot::signal2<VideoChannel*, const std::vector<ConnectionInfo>&> 505 sigslot::signal2<VideoChannel*, const std::vector<ConnectionInfo>&>
508 SignalConnectionMonitor; 506 SignalConnectionMonitor;
509 507
510 void StartMediaMonitor(int cms); 508 void StartMediaMonitor(int cms);
511 void StopMediaMonitor(); 509 void StopMediaMonitor();
512 sigslot::signal2<VideoChannel*, const VideoMediaInfo&> SignalMediaMonitor; 510 sigslot::signal2<VideoChannel*, const VideoMediaInfo&> SignalMediaMonitor;
513 511
514 bool SetVideoSend(uint32_t ssrc, bool enable, const VideoOptions* options); 512 // Register a source and set options.
513 // The |ssrc| must correspond to a registered send stream.
514 bool SetVideoSend(uint32_t ssrc,
515 bool enable,
516 const VideoOptions* options,
517 rtc::VideoSourceInterface<cricket::VideoFrame>* source);
515 webrtc::RtpParameters GetRtpSendParameters(uint32_t ssrc) const; 518 webrtc::RtpParameters GetRtpSendParameters(uint32_t ssrc) const;
516 bool SetRtpSendParameters(uint32_t ssrc, 519 bool SetRtpSendParameters(uint32_t ssrc,
517 const webrtc::RtpParameters& parameters); 520 const webrtc::RtpParameters& parameters);
518 webrtc::RtpParameters GetRtpReceiveParameters(uint32_t ssrc) const; 521 webrtc::RtpParameters GetRtpReceiveParameters(uint32_t ssrc) const;
519 bool SetRtpReceiveParameters(uint32_t ssrc, 522 bool SetRtpReceiveParameters(uint32_t ssrc,
520 const webrtc::RtpParameters& parameters); 523 const webrtc::RtpParameters& parameters);
521 524
522 private: 525 private:
523 // overrides from BaseChannel 526 // overrides from BaseChannel
524 void ChangeState_w() override; 527 void ChangeState_w() override;
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
672 // SetSendParameters. 675 // SetSendParameters.
673 DataSendParameters last_send_params_; 676 DataSendParameters last_send_params_;
674 // Last DataRecvParameters sent down to the media_channel() via 677 // Last DataRecvParameters sent down to the media_channel() via
675 // SetRecvParameters. 678 // SetRecvParameters.
676 DataRecvParameters last_recv_params_; 679 DataRecvParameters last_recv_params_;
677 }; 680 };
678 681
679 } // namespace cricket 682 } // namespace cricket
680 683
681 #endif // WEBRTC_PC_CHANNEL_H_ 684 #endif // WEBRTC_PC_CHANNEL_H_
OLDNEW
« no previous file with comments | « webrtc/media/engine/webrtcvideoengine2_unittest.cc ('k') | webrtc/pc/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698