Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: webrtc/pc/channel.cc

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding TODO. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/channel.h ('k') | webrtc/pc/channel_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 1853 matching lines...) Expand 10 before | Expand all | Expand 10 after
1864 Deinit(); 1864 Deinit();
1865 } 1865 }
1866 1866
1867 bool VideoChannel::SetSink(uint32_t ssrc, 1867 bool VideoChannel::SetSink(uint32_t ssrc,
1868 rtc::VideoSinkInterface<VideoFrame>* sink) { 1868 rtc::VideoSinkInterface<VideoFrame>* sink) {
1869 worker_thread()->Invoke<void>( 1869 worker_thread()->Invoke<void>(
1870 Bind(&VideoMediaChannel::SetSink, media_channel(), ssrc, sink)); 1870 Bind(&VideoMediaChannel::SetSink, media_channel(), ssrc, sink));
1871 return true; 1871 return true;
1872 } 1872 }
1873 1873
1874 void VideoChannel::SetSource( 1874 bool VideoChannel::SetVideoSend(
1875 uint32_t ssrc, 1875 uint32_t ssrc,
1876 bool mute,
1877 const VideoOptions* options,
1876 rtc::VideoSourceInterface<cricket::VideoFrame>* source) { 1878 rtc::VideoSourceInterface<cricket::VideoFrame>* source) {
1877 worker_thread()->Invoke<void>(
1878 Bind(&VideoMediaChannel::SetSource, media_channel(), ssrc, source));
1879 }
1880
1881 bool VideoChannel::SetVideoSend(uint32_t ssrc,
1882 bool mute,
1883 const VideoOptions* options) {
1884 return InvokeOnWorker(Bind(&VideoMediaChannel::SetVideoSend, media_channel(), 1879 return InvokeOnWorker(Bind(&VideoMediaChannel::SetVideoSend, media_channel(),
1885 ssrc, mute, options)); 1880 ssrc, mute, options, source));
1886 } 1881 }
1887 1882
1888 webrtc::RtpParameters VideoChannel::GetRtpSendParameters(uint32_t ssrc) const { 1883 webrtc::RtpParameters VideoChannel::GetRtpSendParameters(uint32_t ssrc) const {
1889 return worker_thread()->Invoke<webrtc::RtpParameters>( 1884 return worker_thread()->Invoke<webrtc::RtpParameters>(
1890 Bind(&VideoChannel::GetRtpSendParameters_w, this, ssrc)); 1885 Bind(&VideoChannel::GetRtpSendParameters_w, this, ssrc));
1891 } 1886 }
1892 1887
1893 webrtc::RtpParameters VideoChannel::GetRtpSendParameters_w( 1888 webrtc::RtpParameters VideoChannel::GetRtpSendParameters_w(
1894 uint32_t ssrc) const { 1889 uint32_t ssrc) const {
1895 return media_channel()->GetRtpSendParameters(ssrc); 1890 return media_channel()->GetRtpSendParameters(ssrc);
(...skipping 516 matching lines...) Expand 10 before | Expand all | Expand 10 after
2412 return data_channel_type_ == DCT_RTP && BaseChannel::ShouldSetupDtlsSrtp_n(); 2407 return data_channel_type_ == DCT_RTP && BaseChannel::ShouldSetupDtlsSrtp_n();
2413 } 2408 }
2414 2409
2415 void DataChannel::OnStreamClosedRemotely(uint32_t sid) { 2410 void DataChannel::OnStreamClosedRemotely(uint32_t sid) {
2416 rtc::TypedMessageData<uint32_t>* message = 2411 rtc::TypedMessageData<uint32_t>* message =
2417 new rtc::TypedMessageData<uint32_t>(sid); 2412 new rtc::TypedMessageData<uint32_t>(sid);
2418 signaling_thread()->Post(this, MSG_STREAMCLOSEDREMOTELY, message); 2413 signaling_thread()->Post(this, MSG_STREAMCLOSEDREMOTELY, message);
2419 } 2414 }
2420 2415
2421 } // namespace cricket 2416 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/pc/channel.h ('k') | webrtc/pc/channel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698