Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: webrtc/media/base/mediachannel.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding TODO. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/media/base/fakemediaengine.h ('k') | webrtc/media/base/videoengine_unittest.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 973 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 const webrtc::RtpParameters& parameters) = 0; 984 const webrtc::RtpParameters& parameters) = 0;
985 virtual webrtc::RtpParameters GetRtpReceiveParameters( 985 virtual webrtc::RtpParameters GetRtpReceiveParameters(
986 uint32_t ssrc) const = 0; 986 uint32_t ssrc) const = 0;
987 virtual bool SetRtpReceiveParameters( 987 virtual bool SetRtpReceiveParameters(
988 uint32_t ssrc, 988 uint32_t ssrc,
989 const webrtc::RtpParameters& parameters) = 0; 989 const webrtc::RtpParameters& parameters) = 0;
990 // Gets the currently set codecs/payload types to be used for outgoing media. 990 // Gets the currently set codecs/payload types to be used for outgoing media.
991 virtual bool GetSendCodec(VideoCodec* send_codec) = 0; 991 virtual bool GetSendCodec(VideoCodec* send_codec) = 0;
992 // Starts or stops transmission (and potentially capture) of local video. 992 // Starts or stops transmission (and potentially capture) of local video.
993 virtual bool SetSend(bool send) = 0; 993 virtual bool SetSend(bool send) = 0;
994 // Configure stream for sending. 994 // Configure stream for sending and register a source.
995 virtual bool SetVideoSend(uint32_t ssrc, 995 // The |ssrc| must correspond to a registered send stream.
996 bool enable, 996 virtual bool SetVideoSend(
997 const VideoOptions* options) = 0; 997 uint32_t ssrc,
998 bool enable,
999 const VideoOptions* options,
1000 rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
998 // Sets the sink object to be used for the specified stream. 1001 // Sets the sink object to be used for the specified stream.
999 // If SSRC is 0, the renderer is used for the 'default' stream. 1002 // If SSRC is 0, the renderer is used for the 'default' stream.
1000 virtual bool SetSink(uint32_t ssrc, 1003 virtual bool SetSink(uint32_t ssrc,
1001 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0; 1004 rtc::VideoSinkInterface<cricket::VideoFrame>* sink) = 0;
1002 // Register a source. The |ssrc| must correspond to a registered send stream.
1003 virtual void SetSource(
1004 uint32_t ssrc,
1005 rtc::VideoSourceInterface<cricket::VideoFrame>* source) = 0;
1006 // Gets quality stats for the channel. 1005 // Gets quality stats for the channel.
1007 virtual bool GetStats(VideoMediaInfo* info) = 0; 1006 virtual bool GetStats(VideoMediaInfo* info) = 0;
1008 }; 1007 };
1009 1008
1010 enum DataMessageType { 1009 enum DataMessageType {
1011 // Chrome-Internal use only. See SctpDataMediaChannel for the actual PPID 1010 // Chrome-Internal use only. See SctpDataMediaChannel for the actual PPID
1012 // values. 1011 // values.
1013 DMT_NONE = 0, 1012 DMT_NONE = 0,
1014 DMT_CONTROL = 1, 1013 DMT_CONTROL = 1,
1015 DMT_BINARY = 2, 1014 DMT_BINARY = 2,
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
1125 // Signal when the media channel is ready to send the stream. Arguments are: 1124 // Signal when the media channel is ready to send the stream. Arguments are:
1126 // writable(bool) 1125 // writable(bool)
1127 sigslot::signal1<bool> SignalReadyToSend; 1126 sigslot::signal1<bool> SignalReadyToSend;
1128 // Signal for notifying that the remote side has closed the DataChannel. 1127 // Signal for notifying that the remote side has closed the DataChannel.
1129 sigslot::signal1<uint32_t> SignalStreamClosedRemotely; 1128 sigslot::signal1<uint32_t> SignalStreamClosedRemotely;
1130 }; 1129 };
1131 1130
1132 } // namespace cricket 1131 } // namespace cricket
1133 1132
1134 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_ 1133 #endif // WEBRTC_MEDIA_BASE_MEDIACHANNEL_H_
OLDNEW
« no previous file with comments | « webrtc/media/base/fakemediaengine.h ('k') | webrtc/media/base/videoengine_unittest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698