Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: webrtc/api/rtpsender.h

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Adding TODO. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/mediastreamprovider.h ('k') | webrtc/api/rtpsender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 void Stop() override; 164 void Stop() override;
165 165
166 RtpParameters GetParameters() const override; 166 RtpParameters GetParameters() const override;
167 bool SetParameters(const RtpParameters& parameters) override; 167 bool SetParameters(const RtpParameters& parameters) override;
168 168
169 private: 169 private:
170 bool can_send_track() const { return track_ && ssrc_; } 170 bool can_send_track() const { return track_ && ssrc_; }
171 // Helper function to construct options for 171 // Helper function to construct options for
172 // VideoProviderInterface::SetVideoSend. 172 // VideoProviderInterface::SetVideoSend.
173 void SetVideoSend(); 173 void SetVideoSend();
174 // Helper function to call SetVideoSend with "stop sending" parameters.
175 void ClearVideoSend();
174 176
175 std::string id_; 177 std::string id_;
176 std::string stream_id_; 178 std::string stream_id_;
177 VideoProviderInterface* provider_; 179 VideoProviderInterface* provider_;
178 rtc::scoped_refptr<VideoTrackInterface> track_; 180 rtc::scoped_refptr<VideoTrackInterface> track_;
179 uint32_t ssrc_ = 0; 181 uint32_t ssrc_ = 0;
180 bool cached_track_enabled_ = false; 182 bool cached_track_enabled_ = false;
181 bool stopped_ = false; 183 bool stopped_ = false;
182 }; 184 };
183 185
184 } // namespace webrtc 186 } // namespace webrtc
185 187
186 #endif // WEBRTC_API_RTPSENDER_H_ 188 #endif // WEBRTC_API_RTPSENDER_H_
OLDNEW
« no previous file with comments | « webrtc/api/mediastreamprovider.h ('k') | webrtc/api/rtpsender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698