Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: webrtc/api/webrtcsession_unittest.cc

Issue 1838413002: Combining SetVideoSend and SetSource into one method. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
239 cricket::TransportChannel* data_rtp_transport_channel() { 239 cricket::TransportChannel* data_rtp_transport_channel() {
240 return rtp_transport_channel(data_channel()); 240 return rtp_transport_channel(data_channel());
241 } 241 }
242 242
243 cricket::TransportChannel* data_rtcp_transport_channel() { 243 cricket::TransportChannel* data_rtcp_transport_channel() {
244 return rtcp_transport_channel(data_channel()); 244 return rtcp_transport_channel(data_channel());
245 } 245 }
246 246
247 using webrtc::WebRtcSession::SetAudioPlayout; 247 using webrtc::WebRtcSession::SetAudioPlayout;
248 using webrtc::WebRtcSession::SetAudioSend; 248 using webrtc::WebRtcSession::SetAudioSend;
249 using webrtc::WebRtcSession::SetCaptureDevice;
250 using webrtc::WebRtcSession::SetVideoPlayout; 249 using webrtc::WebRtcSession::SetVideoPlayout;
251 using webrtc::WebRtcSession::SetVideoSend; 250 using webrtc::WebRtcSession::SetVideoSend;
252 251
253 private: 252 private:
254 cricket::TransportChannel* rtp_transport_channel(cricket::BaseChannel* ch) { 253 cricket::TransportChannel* rtp_transport_channel(cricket::BaseChannel* ch) {
255 if (!ch) { 254 if (!ch) {
256 return nullptr; 255 return nullptr;
257 } 256 }
258 return ch->transport_channel(); 257 return ch->transport_channel();
259 } 258 }
(...skipping 3241 matching lines...) Expand 10 before | Expand all | Expand 10 after
3501 TEST_F(WebRtcSessionTest, SetVideoSend) { 3500 TEST_F(WebRtcSessionTest, SetVideoSend) {
3502 Init(); 3501 Init();
3503 SendAudioVideoStream1(); 3502 SendAudioVideoStream1();
3504 CreateAndSetRemoteOfferAndLocalAnswer(); 3503 CreateAndSetRemoteOfferAndLocalAnswer();
3505 cricket::FakeVideoMediaChannel* channel = media_engine_->GetVideoChannel(0); 3504 cricket::FakeVideoMediaChannel* channel = media_engine_->GetVideoChannel(0);
3506 ASSERT_TRUE(channel != NULL); 3505 ASSERT_TRUE(channel != NULL);
3507 ASSERT_EQ(1u, channel->send_streams().size()); 3506 ASSERT_EQ(1u, channel->send_streams().size());
3508 uint32_t send_ssrc = channel->send_streams()[0].first_ssrc(); 3507 uint32_t send_ssrc = channel->send_streams()[0].first_ssrc();
3509 EXPECT_FALSE(channel->IsStreamMuted(send_ssrc)); 3508 EXPECT_FALSE(channel->IsStreamMuted(send_ssrc));
3510 cricket::VideoOptions* options = NULL; 3509 cricket::VideoOptions* options = NULL;
3511 session_->SetVideoSend(send_ssrc, false, options); 3510 session_->SetVideoSend(send_ssrc, false, options, nullptr);
3512 EXPECT_TRUE(channel->IsStreamMuted(send_ssrc)); 3511 EXPECT_TRUE(channel->IsStreamMuted(send_ssrc));
3513 session_->SetVideoSend(send_ssrc, true, options); 3512 session_->SetVideoSend(send_ssrc, true, options, nullptr);
3514 EXPECT_FALSE(channel->IsStreamMuted(send_ssrc)); 3513 EXPECT_FALSE(channel->IsStreamMuted(send_ssrc));
3515 } 3514 }
3516 3515
3517 TEST_F(WebRtcSessionTest, CanNotInsertDtmf) { 3516 TEST_F(WebRtcSessionTest, CanNotInsertDtmf) {
3518 TestCanInsertDtmf(false); 3517 TestCanInsertDtmf(false);
3519 } 3518 }
3520 3519
3521 TEST_F(WebRtcSessionTest, CanInsertDtmf) { 3520 TEST_F(WebRtcSessionTest, CanInsertDtmf) {
3522 TestCanInsertDtmf(true); 3521 TestCanInsertDtmf(true);
3523 } 3522 }
(...skipping 870 matching lines...) Expand 10 before | Expand all | Expand 10 after
4394 } 4393 }
4395 4394
4396 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test 4395 // TODO(bemasc): Add a TestIceStatesBundle with BUNDLE enabled. That test
4397 // currently fails because upon disconnection and reconnection OnIceComplete is 4396 // currently fails because upon disconnection and reconnection OnIceComplete is
4398 // called more than once without returning to IceGatheringGathering. 4397 // called more than once without returning to IceGatheringGathering.
4399 4398
4400 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests, 4399 INSTANTIATE_TEST_CASE_P(WebRtcSessionTests,
4401 WebRtcSessionTest, 4400 WebRtcSessionTest,
4402 testing::Values(ALREADY_GENERATED, 4401 testing::Values(ALREADY_GENERATED,
4403 DTLS_IDENTITY_STORE)); 4402 DTLS_IDENTITY_STORE));
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698