cricket::VideoFrame cleanup. New width() and height(). Deleted GetChroma* methods.

talk/app/webrtc/objc/RTCI420Frame.mm

Index: talk/app/webrtc/objc/RTCI420Frame.mm
diff --git a/talk/app/webrtc/objc/RTCI420Frame.mm b/talk/app/webrtc/objc/RTCI420Frame.mm
index d8be8ceed14e1aa85b2ca9e95e44ba00b0bea66f..b0f1a33b716cc78a32c91e3ed9beb2349e8ec1b3 100644
--- a/talk/app/webrtc/objc/RTCI420Frame.mm
+++ b/talk/app/webrtc/objc/RTCI420Frame.mm
@@ -36,23 +36,23 @@
 }
 
 - (NSUInteger)width {
-  return _videoFrame->GetWidth();
+  return _videoFrame->width();
 }
 
 - (NSUInteger)height {
-  return _videoFrame->GetHeight();
+  return _videoFrame->height();
 }
 
 - (NSUInteger)chromaWidth {
-  return _videoFrame->GetChromaWidth();
+  return ([self width] + 1) / 2;

[tkchin_webrtc, 2016/03/30 17:35:06]

Is this always going to be true? This assumes that every frame will be I420,
which might not be the case if there is a native handle.

[tkchin_webrtc, 2016/03/30 17:35:06]

dot syntax for properties
self.width
self.height
self.chromaWidth + self.chromeHeight

[perkj_webrtc, 2016/03/31 04:58:23]

Are these actually used for anything? Cant we just remove them here too? If not-
this is actually how these values are calculated today in  videoframe.h.

[nisse-webrtc, 2016/03/31 08:22:17]

Done.

[nisse-webrtc, 2016/03/31 08:22:18]

This is no change in behavior. Probably with the motivation that "chroma" makes
sense only for yuv frames.

 }
 
 - (NSUInteger)chromaHeight {
-  return _videoFrame->GetChromaHeight();
+  return ([self height] + 1) / 2;
 }
 
 - (NSUInteger)chromaSize {

[perkj_webrtc, 2016/03/31 04:58:23]

dito? Unused?

[nisse-webrtc, 2016/03/31 08:22:17]

The chromaSize property appear to be completely unused. So I'm deleting it.

chromaWidth and chromaHeight are used only in RTCOpenGlVideoRenderer.mm. Can
perhaps be removed there, but I think I'd prefer to not do that in this cl.

[pbos-webrtc, 2016/03/31 14:49:09]

Can you put a TODO here to do that?

-  return _videoFrame->GetChromaSize();
+  return [self chromaWidth] * [self chromaHeight];
 }
 
 - (const uint8_t*)yPlane {