Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 1838163002: Change include in metrics.h (change to use systems_wrappers/include/logging.h). (Closed)

Created:
4 years, 8 months ago by åsapersson
Modified:
4 years, 8 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Change include in metrics.h (change to use systems_wrappers/include/logging.h, base logging breaks chromium.fyi). BUG= TBR=mflodman@webrtc.org Committed: https://crrev.com/9c246c4bbeb2f12846c7648feac3d33885645248 Cr-Commit-Position: refs/heads/master@{#12135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/system_wrappers/include/metrics.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
åsapersson
4 years, 8 months ago (2016-03-29 10:13:16 UTC) #4
pbos-webrtc
lgtm
4 years, 8 months ago (2016-03-29 10:13:59 UTC) #5
pbos-webrtc
On 2016/03/29 10:13:59, pbos-webrtc wrote: > lgtm please put in the CL description why (using ...
4 years, 8 months ago (2016-03-29 10:14:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1838163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1838163002/1
4 years, 8 months ago (2016-03-29 10:22:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-29 11:16:29 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 11:16:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c246c4bbeb2f12846c7648feac3d33885645248
Cr-Commit-Position: refs/heads/master@{#12135}

Powered by Google App Engine
This is Rietveld 408576698