Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 1837693002: Remove calls to rtc::scoped_ptr::accept (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 8 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@using-3
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove calls to rtc::scoped_ptr::accept It'll go away soon, when rtc::scoped_ptr becomes a type alias for std::unique_ptr. BUG=webrtc:5520 Committed: https://crrev.com/345807e599f89de716ad84c0cae23a16dbbca705 Cr-Commit-Position: refs/heads/master@{#12144}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -6 lines) Patch
M webrtc/base/win32regkey.cc View 3 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-27 23:55:11 UTC) #2
tommi
lgtm
4 years, 9 months ago (2016-03-28 09:38:40 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1802013002 Patch 80001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-28 09:38:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837693002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837693002/40001
4 years, 8 months ago (2016-03-29 13:06:16 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on ...
4 years, 8 months ago (2016-03-29 15:06:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837693002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837693002/40001
4 years, 8 months ago (2016-03-29 17:13:55 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-29 17:16:40 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-03-29 17:16:48 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/345807e599f89de716ad84c0cae23a16dbbca705
Cr-Commit-Position: refs/heads/master@{#12144}

Powered by Google App Engine
This is Rietveld 408576698