Chromium Code Reviews

Issue 1837213002: [rtcp] ReceiverReport::Parse updated not to use RTCPUtility (Closed)

Created:
4 years, 8 months ago by danilchap
Modified:
4 years, 8 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] ReceiverReport::Parse updated not to use RTCPUtility BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/367bbbf76dbd28ca1e9ff107ec3e83604b65c2dd Cr-Commit-Position: refs/heads/master@{#12164}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Stats (+47 lines, -63 lines)
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h View 1 chunk +3 lines, -4 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.cc View 3 chunks +9 lines, -11 lines 0 comments
M webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report_unittest.cc View 6 chunks +35 lines, -48 lines 0 comments

Messages

Total messages: 8 (3 generated)
åsapersson
lgtm https://codereview.webrtc.org/1837213002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h File webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h (right): https://codereview.webrtc.org/1837213002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h#newcode29 webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h:29: virtual ~ReceiverReport() {} override
4 years, 8 months ago (2016-03-30 11:57:17 UTC) #1
danilchap
https://codereview.webrtc.org/1837213002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h File webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h (right): https://codereview.webrtc.org/1837213002/diff/1/webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h#newcode29 webrtc/modules/rtp_rtcp/source/rtcp_packet/receiver_report.h:29: virtual ~ReceiverReport() {} On 2016/03/30 11:57:17, åsapersson wrote: > ...
4 years, 8 months ago (2016-03-30 12:41:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1837213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1837213002/20001
4 years, 8 months ago (2016-03-30 16:41:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-30 16:43:07 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 16:43:20 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/367bbbf76dbd28ca1e9ff107ec3e83604b65c2dd
Cr-Commit-Position: refs/heads/master@{#12164}

Powered by Google App Engine